Closed
Bug 881838
Opened 11 years ago
Closed 11 years ago
Thimble is apparently cleaning "style" attributes
Categories
(Webmaker Graveyard :: Thimble, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: michiel)
References
Details
(Whiteboard: s=2013w24 p=1)
Attachments
(1 file)
Tried to publish with <p style="color:yellow">, ends up being <p style="">, this is not good.
if this is going wrong, it's going to be in the github.com/mozilla/htmlsanitizer.org version of Bleach... probably
Apparently passing a non-empty array for CSS whitelisting crashses the htmlsanitizer.
fixed mozilla/htmlsanitizer.org to not validate the style array in the same way as tags, which fixed it, which then still needs a CSS whitelist, which will be added as bug attachment
Attachment #761127 -
Flags: review?(chris)
|
||
Comment 5•11 years ago
|
||
Comment on attachment 761127 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/113 R+ with a ticket to figure out why transform functions in CSS aren't being allowed.
Attachment #761127 -
Flags: review?(chris) → review+
filed https://bugzilla.mozilla.org/show_bug.cgi?id=881893 as followup
|
||
Comment 7•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/thimble.webmaker.org https://github.com/mozilla/thimble.webmaker.org/commit/17fb276b78ee25c0e029197dce5f785f7b85d391 Merge pull request #113 from Pomax/bug881838 added the CSS property list
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•