881967 - [code quality] Fix event listener leaks

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Matt Basta [:basta]]

Event listeners are getting leaked left and right. Some page loads can add as many as 20 event listeners to the DOM which don't get cleaned up on navigation.

It's likely that element references are being cached by jQuery or getting somehow stored in the global scope. When the detached DOM nodes don't get GCed, their event listeners don't get GCed. This causes a buildup over time, slowing performance and ballooning the memory footprint.

On desktop, the memory footprint can expand past the 1GB mark if you browse around long enough, mostly because events aren't getting GCed, which means that closures aren't getting GCed, which means that compiled code isn't getting GCed.

Comment 1

[Matt Basta [:basta]]

This was mostly finished here:

https://github.com/mozilla/fireplace/commit/b1ec58e3b714c6487583cdeab8ce4cff9d616a60

There are still some rough edges in reviews, but they aren't huge perf hits.

Comment 2

[Victor Carciu]

Can you please add some STRs or mark this bug as [qa-] ?