Closed
Bug 882025
Opened 11 years ago
Closed 11 years ago
layout-change test add-on has a lot of output due to a deprecation error
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Unassigned)
Details
Attachments
(1 file)
Testing layout-change... Using binary at '/Applications/Firefox.app/Contents/MacOS/firefox-bin'. Using profile at '/var/folders/lc/2v6jzk5525gd4l6zr5hxt2yc0000gn/T/tmpZR00Fv.mozrunner'. Running tests on Firefox 21.0/Gecko 21.0 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under darwin/x86. ........................................error: layout-change: DEPRECATED: The addon-page module is deprecated.In the new Firefox UI design all pages will include navigational elements;once the new design ships, using the addon-page module will not have any effect. Traceback (most recent call last): File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/test/harness.js", line 592, in runTests nextIteration(); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/test/harness.js", line 416, in nextIteration findAndRunTests(loader, nextIteration); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/test/runner.js", line 125, in findAndRunTests onDone: nextIteration File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 457, in startMany runNextTest(this); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 452, in runNextTest self.start({test: test, onDone: runNextTest}); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 483, in start this.test.testFunction(this); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/test.js", line 72, in null test(assert); File "resource://test-layout-change-at-jetpack/layout-change/lib/main.js", line 144, in exports["test compatibility"] assert.equal(require("addon-page"), File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/toolkit/loader.js", line 339, in require freeze(load(loader, module)); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js", line 133, in options<.load result = load(loader, module); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/toolkit/loader.js", line 237, in load evaluate(sandbox, module.uri); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/toolkit/loader.js", line 210, in evaluate : loadSubScript(uri, sandbox, encoding); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/addon-page.js", line 22, in null "The addon-page module is deprecated." + File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/util/deprecate.js", line 16, in deprecateUsage let stack = get().slice(2); ..............info: layout-change: [JavaScript Error: "layout-change: DEPRECATED: The addon-page module is deprecated.In the new Firefox UI design all pages will include navigational elements;once the new design ships, using the addon-page module will not have any effect. Traceback (most recent call last): File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/test/harness.js", line 592, in runTests nextIteration(); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/test/harness.js", line 416, in nextIteration findAndRunTests(loader, nextIteration); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/test/runner.js", line 125, in findAndRunTests onDone: nextIteration File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 457, in startMany runNextTest(this); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 452, in runNextTest self.start({test: test, onDone: runNextTest}); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 483, in start this.test.testFunction(this); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/test.js", line 72, in null test(assert); File "resource://test-layout-change-at-jetpack/layout-change/lib/main.js", line 144, in exports["test compatibility"] assert.equal(require("addon-page"), File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/toolkit/loader.js", line 339, in require freeze(load(loader, module)); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js", line 133, in options<.load result = load(loader, module); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/toolkit/loader.js", line 237, in load evaluate(sandbox, module.uri); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/toolkit/loader.js", line 210, in evaluate : loadSubScript(uri, sandbox, encoding); File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/addon-page.js", line 22, in null "The addon-page module is deprecated." + File "resource://extensions.modules.test-layout-change-at-jetpack.commonjs.path/sdk/util/deprecate.js", line 16, in deprecateUsage let stack = get().slice(2); "] warn: layout-change: 1 warnings or errors were logged to the platform's nsIConsoleService, which could be of no consequence; however, they could also be indicative of aberrant behavior. 54 of 54 tests passed. Total time: 2.019677 seco
Reporter | ||
Comment 1•11 years ago
|
||
Pointer to Github pull-request
Reporter | ||
Updated•11 years ago
|
Attachment #761285 -
Flags: review?(jsantell)
Comment 2•11 years ago
|
||
Comment on attachment 761285 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1028 Looks good! Reminds me we need docs for `test/loader`, making a ticket
Attachment #761285 -
Flags: review?(jsantell) → review+
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d27dac697ccde989fa6c71e1a883aa692326502a Bug 882025 use a LoaderWithHookedConsole for deprecated modules in the layout-change test add-on https://github.com/mozilla/addon-sdk/commit/2ca837381a61b7aec8728a0f9bb560777c838647 Merge pull request #1028 from erikvold/882025 Bug 882025 use a LoaderWithHookedConsole for deprecated modules in the layout-change test add-on r=@jsantell
Comment 4•11 years ago
|
||
Looks like it's fixed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Commits pushed to australis at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d27dac697ccde989fa6c71e1a883aa692326502a Bug 882025 use a LoaderWithHookedConsole for deprecated modules in the layout-change test add-on https://github.com/mozilla/addon-sdk/commit/2ca837381a61b7aec8728a0f9bb560777c838647 Merge pull request #1028 from erikvold/882025
You need to log in
before you can comment on or make changes to this bug.
Description
•