882306 - Use CSS to make buttons look enabled while customizing instead of messing with buttons' disabled states in CustomizeMode.jsm

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Dão Gottwald [:dao]]

Spun off from bug 879980... Where we use CSS to implement the disabled state, we could easily stop doing that while customizing: http://hg.mozilla.org/projects/ux/file/899389c30a16/browser/themes/windows/browser.css#l338

We should then get rid of this code: http://hg.mozilla.org/projects/ux/file/d34b32544b06/browser/components/customizableui/src/CustomizeMode.jsm#l362

Comment 1

[:Gijs (he/him)]

Attachment: Remove old code to do this

This part I'm fairly sure about.

Comment 2

[:Gijs (he/him)]

Attachment: Check for toolbarpaletteitem parents

This part, however...

It'd simplify things slightly to use #mainwindow:not([customizing]), but I guess it'd also be slower...

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 762176 [details] [diff] [review]
Check for toolbarpaletteitem parents

the linux part is fine, but I think we're better off with #main-window:not([customizing]) for windows and osx

Comment 4

[:Gijs (he/him)]

Attachment: Use a main window + attribute selector on OS X and Windows

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 762574 [details] [diff] [review]
Use a main window + attribute selector on OS X and Windows

>--- a/browser/themes/linux/browser.css
>+++ b/browser/themes/linux/browser.css

> #cut-button {
>   list-style-image: url("moz-icon://stock/gtk-cut?size=toolbar") !important;
> }
>-#cut-button[disabled="true"] {
>+:not(toolbarpaletteitem) > toolbaritem > #cut-button[disabled="true"] {
>   list-style-image: url("moz-icon://stock/gtk-cut?size=toolbar&state=disabled") !important;
> }
> 
> #copy-button {
>   list-style-image: url("moz-icon://stock/gtk-copy?size=toolbar") !important;
> }
>-#copy-button[disabled="true"] {
>+:not(toolbarpaletteitem) > toolbaritem > #copy-button[disabled="true"] {
>   list-style-image: url("moz-icon://stock/gtk-copy?size=toolbar&state=disabled") !important;
> }
> 
> #paste-button {
>   list-style-image: url("moz-icon://stock/gtk-paste?size=toolbar") !important;
> }
>-#paste-button[disabled="true"] {
>+:not(toolbarpaletteitem) > toolbaritem > #paste-button[disabled="true"] {
>   list-style-image: url("moz-icon://stock/gtk-paste?size=toolbar&state=disabled") !important;
> }

Please use #edit-controls instead of toolbaritem in these selectors.

Comment 6

[:Gijs (he/him)]

Pushed: https://hg.mozilla.org/projects/ux/rev/d9f547e97bf8

Comment 7

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/d9f547e97bf8