882357 - devicemanagerADB getProcessList / processExists sometimes returns wrong pid

Status: RESOLVED WONTFIX

(Testing :: Mozbase, defect)

Description

[Geoff Brown [:gbrown]]

devicemanager.processExists uses getProcessList to retrieve a list of pids and process names, then returns the pid associated with a specified process name. 

devicemanagerADB.getProcessList retrieves process info returned by ps, but the ps format is different on different devices. getProcessList tries to detect the format and adjust the returned process list accordingly, but the check is too simplistic:

            # we need to figure out if this is "user pid name" or "pid user vsz stat command"
            if els[1].isdigit():
                ret.append(list([int(els[1]), els[len(els) - 1], els[0]]))
            else:
                ret.append(list([int(els[0]), els[len(els) - 1], els[1]]))

On the Galaxy Nexus with Android 4.0.1, ps produces:

PID   USER     TIME   COMMAND
    1 root       0:04 /init
    2 root       0:00 [kthreadd]
    3 root       0:00 [ksoftirqd/0]
...
 9916 root       0:00 [kworker/1:0]
10030 10038      0:03 {a.fennec_mozdev} org.mozilla.fennec_mozdev
10113 root       0:00 /system/bin/sh -c ps
10115 root       0:00 ps

as a result, processExist may return 10038 as Fennec's pid.

Comment 1

[Geoff Brown [:gbrown]]

Not such a problem with modern Android.