88254 - Should include URL if you can't delete a component

Status: RESOLVED WORKSFORME

(Bugzilla :: Administration, task, P3)

Description

[Stephen Rasku]

If there are bugs outstanding on a component, it should include a URL you can
click on that will display those bugs.

Comment 1

[Andreas Franke (gone)]

-> Bugzilla product, Administration component, reassigning.

Comment 2

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 3

[Vlad Dascalu]

Attachment: Patch.

Comment 4

[Vlad Dascalu]

Tested on the current CVS tip; applies correctly, has the expected result.

Comment 5

[GavinS]

2 things:

1) I think you need to url_quote() the component, and

2) Would it be neater to have the number-of-bugs-text link to the buglist, like
this:

"Sorry, there are <a href="xxx">$bugs</a> bugs..."

Comment 6

[Jouni Heikniemi]

Comment on attachment 128375 [details] [diff] [review]
Patch.

>     if ($bugs) {
>+        my $link = "<p>You can view these bugs <a href=\"buglist.cgi?component=$component\">here</a>.";
>         if (!Param("allowbugdeletion")) {
>             print "Sorry, there are $bugs bugs outstanding for this component. 
> You must reassign those bugs to another component before you can delete this
> one.";
>+            print $link;
>             PutTrailer($localtrailer);
>             exit;
>         }

1) GavinS' previous comments need to be addressed
2) Why use the temporary variable $link? If using it, declare it inside the
block where it's used (if !Param(...)).
3) The bug list link works unexpectedly if several products have a component
with the same name.

Comment 7

[Joel Peshkin]

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being
retargeted to 2.20
If you plan to act on one immediately, go ahead and pull it back to 2.18.

Comment 8

[GavinS]

This was fixed as part of the templatisation