882618 - [ja, ja-JP-mac] Remove inactive searchplugins from mobile/searchplugins

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Francesco Lodolo [:flod]]

google-jp.xml

I'm running some tests on searchplugins and this file is inside the mobile/searchplugins folder for both ja and ja-JP-mac but is unused (not in list.txt, you're currently using en-US google). 

Is there a specific reason for keeping it? If not, please remove this file and add a link to the changeset in this bug.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/file/0ef8d26fe225/mobile/searchplugins

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/file/d067ee5512dd/mobile/searchplugins

Comment 1

[dynamis (Tomoya ASAI)]

Sorry, when we start fennec ja l10n we've talked about using specific version for ja locale but actually using global (en-US) one so far.

So, we can remove it now. (add it again if we'll use it)

Comment 2

[Francesco Lodolo [:flod]]

(In reply to dynamis (Tomoya ASAI) from comment #1)
> So, we can remove it now. (add it again if we'll use it)

You can go on and commit the change to your repository, please reference this bug in the commit message (e.g. "Bug 882618 - [ja, ja-JP-mac] Remove inactive searchplugin google-jp.xml from mobile/searchplugins"

Comment 3

[Nagato KASAKI]

Attachment: remove google-jp.xml

Comment 4

[Francesco Lodolo [:flod]]

Note that the file must be removed also on ja-JP-mac
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/file/d067ee5512dd/mobile/searchplugins

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 785639 [details] [diff] [review]
remove google-jp.xml

Review of attachment 785639 [details] [diff] [review]:
-----------------------------------------------------------------

Patch is good. When landing please refer to this bug in the commit message.

As said, a similar change must be applied to ja-JP-mac since there's the same problem.

Comment 6

[Nagato KASAKI]

(In reply to Francesco Lodolo [:flod] from comment #5)
Thank you for your review and comment.

I committed on ja and ja-JP-mac.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/1b30ab85a0df
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/bbf46a7c06d6

Comment 7

[Francesco Lodolo [:flod]]

Thanks, both commits look good :-)