882692 - [Audio] AMR_WB Audio in 3gp container is not playing

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[mbarone]

STR

1. Open Music app and load an AMR_WB audio format in 3gp container

ACTUAL RESULT
The media file is not played

EXPECTED RESULT
The media file should be played

Comment 1

[Jason Smith [:jsmith]]

I don't believe we support playing of AMR media types off of the open web right now. We only plan to support it for the MMS-specific use cases. I believe that's intended behavior.

Roc - Can you confirm?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Jason Smith [:jsmith] from comment #1)
> I don't believe we support playing of AMR media types off of the open web
> right now. We only plan to support it for the MMS-specific use cases. I
> believe that's intended behavior.

That's definitely what I want!

Comment 3

[Jason Smith [:jsmith]]

Closing as invalid as this is expected, as we don't intend to support AMR media types. If you concerns about this, feel free follow with Sandip.

Comment 4

[Marco Chen [:mchen]]

Hi all,

As I know that V1.1 just restricted the web content or apps who's permission is under APP_STATUS_PRIVILEGED. But pre-installed music app would be APP_STATUS_CERTIFIED so music app should be allowed to play 3gp or amr.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Marco Chen [:mchen] from comment #4)
> Hi all,
> 
> As I know that V1.1 just restricted the web content or apps who's permission
> is under APP_STATUS_PRIVILEGED. But pre-installed music app would be
> APP_STATUS_CERTIFIED so music app should be allowed to play 3gp or amr.

I'm not sure we should allow playing of media content with an AMR media type, even in the music app.

Comment 6

[Marco Chen [:mchen]]

(In reply to Jason Smith [:jsmith] from comment #5)
> I'm not sure we should allow playing of media content with an AMR media
> type, even in the music app.

The current Gecko's implementation on V1.1 allowed music app to play amr in 3gp container so I think the bug here is really an issue. If you still have a concern on supporting amr in 3gp maybe you can fire another bug to disable it.

Comment 7

[Jason Smith [:jsmith]]

(In reply to Marco Chen [:mchen] from comment #6)
> (In reply to Jason Smith [:jsmith] from comment #5)
> > I'm not sure we should allow playing of media content with an AMR media
> > type, even in the music app.
> 
> The current Gecko's implementation on V1.1 allowed music app to play amr in
> 3gp container so I think the bug here is really an issue. If you still have
> a concern on supporting amr in 3gp maybe you can fire another bug to disable
> it.

I think this is only valid bug if there's agreement between multiple groups that we should support that use case. To my understanding, I believe we do not want to support the use case you are describing.

I'm putting needinfo on Sandip to figure out what to do here.

Comment 8

[Jason Smith [:jsmith]]

Note - I should mention that this bug was filed as a general issue with AMR media types, not specific to the music app. I'm following up over email what we want to do with the Music app.

Comment 9

[Jason Smith [:jsmith]]

Sandip over email mentions that we should only be supporting open codecs in our platform. He'll add more detail here later.

If AMR media types isn't disabled in the music app, then that's a bug which should be fixed.

Comment 10

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #9)
> Sandip over email mentions that we should only be supporting open codecs in
> our platform. He'll add more detail here later.
> 
> If AMR media types isn't disabled in the music app, then that's a bug which
> should be fixed.

Actually, disregard this statement. I re-read the product spec on this.

AMR-NB & AMR-WB media type formats should be able to be played in the music app. They should not be able to be played on the web, however. So this actually is a valid bug then, but it's a music app specific issue.

Comment 11

[Jason Smith [:jsmith]]

According to the product spec, this was supposed to be supported in 1.01. I'm guessing this is a regression then.

Comment 12

[Wayne Chang [:wchang]]

Per comment 6, comment 11 marking leo+.

Marco, can someone look at this from Taipei?

Comment 13

[Dominic Kuo [:dkuo]]

Wayne, this issue is because the metadata parser of music app filter out some supported formats, AMR_WB audio in 3gp container is probably one of them, and bug 882099 will fix this.

mbarone, can you attach your test file? thanks.

Comment 14

[Marco Chen [:mchen]]

Dominic already replied this so remove the needinfo.

Comment 15

[mbarone]

Attachment: File

Comment 16

[Dominic Kuo [:dkuo]]

Attachment: Hex dump of Content-01_AMR-WB_6.6kbps_Speech01.3gp

Thanks mbarone.

The major_brand is "3gp5" and compatible_brands is "isom" as gecko expected in bug 882099 comment 6.

Comment 17

[Jason Smith [:jsmith]]

Renom. We just minused bug 882669 and closed it as not valid for the other AMR type. Is this not valid as well?

Comment 18

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #17)
> Renom. We just minused bug 882669 and closed it as not valid for the other
> AMR type. Is this not valid as well?

Meant to say bug 882689 there.

Comment 20

[Chris Lee [:clee]]

I've updated bug 882689 as a dup instead of invalid.

Per comment 10, this is a valid bug.  Changing status back to leo+.

Comment 21

[Dominic Kuo [:dkuo]]

Update: this issue will be also fixed by the patch of bug 882683.

Comment 22

[Dominic Kuo [:dkuo]]

Fixed by bug 882683.

Comment 23

[isabelrios]

It is possible to play the content: Content-01_AMR-WB_6.6kbps_Speech01 from music app. Also, it is possible to attach and send the content successfully in a MMS. 

Verified with unagi v1-train 07/15 build:
Gecko-2b310a1
Gaia-d52ce22
ref ril