Closed
Bug 882800
Opened 11 years ago
Closed 11 years ago
[AccessFu] Use IndieUI inspired scroll request events
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: eeejay, Assigned: eeejay)
Details
(Keywords: dev-doc-needed)
Attachments
(1 file, 1 obsolete file)
Synthesizing keyboard events to a related slider widget was crazy.. IndieUI has a good path forward, we don't have to wait for it. We could use CusomEvent for now.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #762158 -
Flags: review?(dbolter)
Comment 2•11 years ago
|
||
Comment on attachment 762158 [details] [diff] [review] Use IndieUI inspired scroll requests. Review of attachment 762158 [details] [diff] [review]: ----------------------------------------------------------------- I assume there is a gaia piece to this that sets the uiactions attribute? ::: accessible/src/jsat/content-script.js @@ +196,5 @@ > + 'scrollrequest', true, true, > + ObjectWrapper.wrap(details, elem.ownerDocument.defaultView)); > + let unhandled = elem.dispatchEvent(evt); > + if (!unhandled) > + return; Optional nit: The gecko in me wonders if this can just be if (elem.dispatchEvent(evt) == 0) return; Would that work?
Attachment #762158 -
Flags: review?(dbolter) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Good call. Carrying over r+
Attachment #762158 -
Attachment is obsolete: true
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee84aacb4de
Assignee: nobody → eitan
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4ee84aacb4de
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
Updated•11 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•