Closed
Bug 883147
Opened 11 years ago
Closed 11 years ago
Bookmark star icon missing for hidpi displays on OSX
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Keywords: regression, Whiteboard: [Australis:M7])
Attachments
(1 file)
|
917 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
I suspect this regressed after bug 856665 landed. Patch coming.
|
Assignee | |
Comment 1•11 years ago
|
||
We just blindly doubled the coordinates for the bookmarks menu button, assuming that Toolbar@2x was the same as Toolbar... Well, it's not. At least, not for now. The WebRTC button is missing from Toolbar@2x. This'll all get sorted once bug 877335 lands. In the meantime, this is a stopgap fix.
Attachment #762681 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•11 years ago
|
Attachment #762681 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
||
Comment 2•11 years ago
|
||
Pushed, https://hg.mozilla.org/projects/ux/rev/0384f4c209f9
Whiteboard: [Australis:M7] → [Australis:M7][fixed-in-ux]
|
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0384f4c209f9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M7][fixed-in-ux] → [Australis:M7]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•