Closed Bug 883369 Opened 11 years ago Closed 11 years ago

refactor "make details" bar to prevent CSS clobbering

Categories

(Webmaker Graveyard :: Thimble, defect)

x86
macOS
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: michiel, Assigned: kate)

References

Details

Attachments

(1 file)

we need to refactor the "make details" bar on published pages so that it lives in its own iframe, rather than details in an iframe, make details bar on the page
first steps: making a absolute bar with top/left/right:0, to at least make body padding not affect our bar.
Assignee: nobody → kate
Severity: normal → blocker
Status: NEW → ASSIGNED
Blocks: 883419
I also added a few things for mobile, but noticed that we need to set the right device-width meta-tag.
Attachment #762993 - Flags: review?(pomax)
Comment on attachment 762993 [details]
https://github.com/mozilla/thimble.webmaker.org/pull/130/files

certainly good enough for now.
Attachment #762993 - Flags: review?(pomax) → review+
https://github.com/mozilla/thimble.webmaker.org/commit/86581de6ee9b64f7fcabfdf44ded6d5e4d457e4f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: