Closed
Bug 883491
Opened 11 years ago
Closed 11 years ago
persona only allows "siteLogo" for https connections, impairing localhost testing
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: michiel, Assigned: mjschranz)
Details
Attachments
(1 file)
persona apparently does not allowed the "siteLogo" parameter when running HTTP, which means localhost testing breaks if we use it without checking which protocol we're running on =(
|
||
Comment 1•11 years ago
|
||
That is so unfortunate, and I have to comment this line out everytime when I want to do something now. https://github.com/mozilla/webmaker.org/blob/master/public/sso/include.html#L73
|
Assignee | |
Comment 2•11 years ago
|
||
Alas until they add in some other support (such as DATA URIs) we don't have an option here other than checking protocol and flipping it on/off based on that. See https://github.com/mozilla/browserid/issues/3314
Assignee: nobody → schranz.m
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #763106 -
Flags: review?(pomax)
|
||
Updated•11 years ago
|
Attachment #763106 -
Flags: review?(pomax)
Attachment #763106 -
Flags: review?(kieran.sedgwick)
Attachment #763106 -
Flags: review-
|
|
||
Updated•11 years ago
|
Attachment #763106 -
Flags: review?(kieran.sedgwick)
Attachment #763106 -
Flags: review-
Attachment #763106 -
Flags: review+
|
||
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/c7966c52b8e802306ddf19ce544d4af0299aabb7 Fix Bug 883491 - Specify site Logo for Persona only over HTTPs to prevent login breakage
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•