883532 - convert uses of nsIDocShellHistory in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[:aceman]

I get this permanent exception when starting Thunderbird:

Error: Places database may be locked: [Exception... "Could not convert JavaScript argument arg 0 [nsISupports.QueryInterface]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: chrome://messenger/content/specialTabs.js :: specialTabs.openSpecialTabsOnStartup :: line 482"  data: no]
Source file: chrome://messenger/content/specialTabs.js
Line: 485

That is this code:
// enable global history
try {
  browser.docShell.QueryInterface(Components.interfaces.nsIDocShellHistory)
         .useGlobalHistory = true;
} catch(ex) {
  Components.utils.reportError("Places database may be locked: " + ex);
}

nsIDocShellHistory was merged into nsIDocShell in bug 882079.

There is also one occurrence in Seamonkey at http://mxr.mozilla.org/comm-central/source/suite/common/src/nsSuiteGlue.js#200

Comment 1

[:aceman]

Attachment: patch

The TB part was tested and no longer produces the exception. I did not test what the feature actually enables, but the conversion pattern is the same as in bug 882079.

The Seamonkey part is untested.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/5291452fffc9