883681 - puppetAgain should not force ifcfg management

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Justin Wood (:Callek)]

Attachment: [puppet320] v1

So today in final stages of setting up seamonkey's puppetmaster I did a reboot, which then brought the host down.

:fox2mike noticed it had a modified ifcfg-eth0 which was forcing it to try to use DHCP which of course, community doesn't have available.

This patch allows us to mark it to not be managed (so we don't blow away the proper ifcfg)

Comment 1

[Justin Wood (:Callek)]

Comment on attachment 763289 [details] [diff] [review]
[puppet320] v1

Review of attachment 763289 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/network/manifests/init.pp
@@ +2,4 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  class network {
> +    import config

err include ::config

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 763289 [details] [diff] [review]
[puppet320] v1

Review of attachment 763289 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine.  Don't forget to document the new config var.

Comment 3

[Justin Wood (:Callek)]

http://hg.mozilla.org/users/dmitchell_mozilla.com/puppet320/rev/4fb76299ca9d

https://wiki.mozilla.org/index.php?title=ReleaseEngineering%2FPuppetAgain%2FModules%2Fconfig&action=historysubmit&diff=667380&oldid=666847