883895 - Part of <select> popup is off-screen if <select> is near the edge of the screen

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[firefox]

Attachment: drop-list error.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/27.0.1453.110 Safari/537.36

Steps to reproduce:

When the SELECT element is close to the right of the physical screen, it is displayed partly off screen. See screenshot.


Actual results:

When the SELECT element is close to the bottom of the physical screen, it is displayed partly off screen. See screenshot.


Expected results:

It should be displayed.

Comment 1

[firefox]

Attachment: Correct selecting drop-list

Comment 2

[Ada [:adalucinet]]

Reporter, could you please provide a link to a public page that has this issue?

Comment 3

[firefox]

(In reply to Alexandra Lucinet [QA] from comment #2)
> Reporter, could you please provide a link to a public page that has this
> issue?

http://hobby.dn.ua/123/address_book.html

Comment 4

[firefox]

(In reply to firefox from comment #3)
> (In reply to Alexandra Lucinet [QA] from comment #2)
> > Reporter, could you please provide a link to a public page that has this
> > issue?
> 
> http://hobby.dn.ua/123/address_book.html

select from "Warehouse" drop-list

Comment 5

[Ada [:adalucinet]]

Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20100101 Firefox/22.0
Mozilla/5.0 (Windows NT 6.1; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20130718 Firefox/24.0
Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20130718 Firefox/25.0

It works for me with Firefox 22.0 (Build ID: 20130618035212), Firefox 23 beta 6 (Build ID: 20130715155216), Aurora 24.a02 (Build ID: 20130718004004) and Nightly 25.0a1 (Build ID: 20130718030201): when I resize the window, the Warehouse drop-down list is displayed entirely, but off screen. I've encountered the same behavior with Opera and Chrome.

Reporter, is it still an issue for you with the latest builds?

Comment 7

[:Gijs (he/him)]

Yes, this is still current. On Windows (steps courtesy of the dupe):

Open your browser to [maximized mode]
Visit https://bugzilla.mozilla.org/page.cgi?id=productdashboard.html

Through any inspector (embedded or Firebug), set the following css styles:

select[name="product"] {
    width: 90px;
    float: right !important;
}

then click the product selector which is now on the far right of the screen.

The right side of the dropdown is displayed offscreen.

Neil, do you know anything about this code, and/or do you know someone who does?

Comment 8

[Neil Deakin]

I don't. Might ask mats about this though, I think.

Comment 9

[Mats Palmgren (inactive)]

We don't have any code that adjusts the x-offset of the dropdown menu to try to keep it
inside the screen edges horizontally (we do it vertically though).  Adding that functionality
seems like a reasonable enhancement request though.

Comment 11

[Nootan Ghimire]

Can anyone give me the info on where is the code for this located? I want to take a look. (and possibly modify, at least for myself).

Comment 12

[Mats Palmgren (inactive)]

GetAvailableDropdownSpace() calculates the available space above / below the contol.
It might be possible to extend to also calculate available space to the left / right.
http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsComboboxControlFrame.cpp#546

Near the end of AbsolutelyPositionDropDown() there's some code that shifts the menu
horizontally for RTL.  That's probably a good place to take the available left / right
space into account.
http://mxr.mozilla.org/mozilla-central/source/layout/forms/nsComboboxControlFrame.cpp#604

Comment 13

[Nootan Ghimire]

(In reply to Mats Palmgren (:mats) from comment #12)
> GetAvailableDropdownSpace() calculates the available space above / below the
> contol.
> It might be possible to extend to also calculate available space to the left
> / right.
> http://mxr.mozilla.org/mozilla-central/source/layout/forms/
> nsComboboxControlFrame.cpp#546
> 
> Near the end of AbsolutelyPositionDropDown() there's some code that shifts
> the menu
> horizontally for RTL.  That's probably a good place to take the available
> left / right
> space into account.
> http://mxr.mozilla.org/mozilla-central/source/layout/forms/
> nsComboboxControlFrame.cpp#604

Thanks for the info. I've another query though, Do we have any code that returns the width of th control (combobox in this case). I was looking through the links provided and could not find/implement the "width" equivalent of "GetHeightOfARow" . If there is some code available to do that. Can you please point me to the code. I am sorry I couldn't understand much source codes and search.

Comment 14

[Mats Palmgren (inactive)]

I think you can use GetRect() here to get the position and size of the nsComboboxControlFrame.

Comment 15

[Nootan Ghimire]

This looks to be solved when E10 is enabled. (i.e., in Nightly)

The UI is a bit different (and nice) though. Does this mean this will no longer be any bug in the near future?

And Is there any Code documentation that I could possibly read and figure out about different functions?

Comment 16

[Mats Palmgren (inactive)]

(In reply to nootan.ghimire from comment #15)
> Does this mean this will no
> longer be any bug in the near future?

Yeah, perhaps this isn't worth fixing for non-e10s.  There are lot's of other
bugs to work on if you want to, see:
https://developer.mozilla.org/en/docs/Introduction#Step_2_-_Find_something_to_work_on

> And Is there any Code documentation that I could possibly read and figure
> out about different functions?

For Layout, the most relevant documentation is in the header files under layout/ .
Feel free to ask in #developers or #layout if you have questions on the code.

Comment 18

[Lars]

Any update on this?
As you see this still a problem and e10 is still not available for most of the users I guess (at least for me it is deactivated because I have Add-ons installed...).

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates.
:emilio, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 20

[Emilio Cobos Álvarez (:emilio)]

This works with the e10s dropdown now.