Closed
Bug 884011
Opened 11 years ago
Closed 11 years ago
Update Firefox Branding
Categories
(Firefox :: General, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 24
People
(Reporter: shorlander, Assigned: shorlander)
References
Details
(Keywords: verifyme)
Attachments
(2 files, 1 obsolete file)
4.24 MB,
patch
|
Dolske
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
4.24 MB,
text/x-patch
|
Details |
This is mostly an image swap, however I did change a few things for retina displays: - Unified the about:home and about dialog logos and changed the size - Switched the wordmark with an SVG version of the most recent wordmark Currently building this on Linux and Windows to test. Seems to work fine on OS X regular DPI and HiDPI, Snow Leopard through Mountain Lion. Some of these bugs are confidential so marking for now. Can't keep it confidential once we check it in though :)
Attachment #763760 -
Flags: review?(gavin.sharp)
Assignee | ||
Comment 1•11 years ago
|
||
Oh, also cleaned up the disk image stuff. Lined up icons, wordmark and arrow, made it larger and updated the graphic. Tried to make it retina ready however we can't do that and have it work on Snow Leopard.
Comment 2•11 years ago
|
||
Comment on attachment 763760 [details] [diff] [review] Update Firefox Branding - 01 Review of attachment 763760 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/base/content/aboutDialog.css @@ +6,5 @@ > width: 620px; > } > > #rightBox { > + background-image: url("chrome://branding/content/about-wordmark.svg"); You'll to add this file to Nightly + Aurora + Unofficial. ::: browser/base/content/abouthome/aboutHome.css @@ +44,5 @@ > #brandLogo { > + height: 192px; > + width: 192px; > + margin: 22px auto 31px; > + background-image: url("chrome://branding/content/about-logo.png"); If this file is changing size, can you update the other branding version of this file so they don't end up scaled funny? Ideally we should keep the various branding flavors as similar as possible. @@ +361,5 @@ > */ > @media not all and (max-resolution: 1dppx) { > + #brandLogo { > + background-image: url("chrome://branding/content/about-logo@2x.png"); > + } Also need Nightly + Aurora + Unofficial versions of this new file, or there won't be any logo.
Attachment #763760 -
Flags: review?(gavin.sharp) → review-
Assignee | ||
Comment 3•11 years ago
|
||
Added additional about-wordmark.svg files, about-logo@2x for all and made sizes consistent.
Attachment #763760 -
Attachment is obsolete: true
Attachment #763966 -
Flags: review?(dolske)
Assignee | ||
Updated•11 years ago
|
Attachment #763966 -
Attachment is patch: true
Attachment #763966 -
Attachment mime type: text/x-patch → text/plain
Updated•11 years ago
|
Attachment #763966 -
Flags: review?(dolske) → review+
Assignee | ||
Updated•11 years ago
|
Group: mozilla-corporation-confidential
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 763966 [details] [diff] [review] Update Firefox Branding - 02 [Approval Request Comment] Bug caused by (feature/regressing bug #): Updating Firefox Icons across properties, also fixes low-res icons on retina screens User impact if declined: Will have outdated icons Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): Low risk, mostly image swaps some CSS tweaks String or IDL/UUID changes made by this patch:
Attachment #763966 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #763966 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•11 years ago
|
||
Removed the Firefox® from about-wordmark.svg Will handle that in bug 833943
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0d1677cc3e8
Keywords: checkin-needed
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f0d1677cc3e8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Hi, out of sheer curiosity: what's the reason for the new/improved Firefox logo? Is there an announcement or a newsgroup discussion or anything else you can point me? Thanks!
Comment 10•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ebfdc93638dd
status-firefox23:
--- → fixed
Target Milestone: Firefox 23 → Firefox 24
Updated•11 years ago
|
relnote-firefox:
--- → ?
Updated•11 years ago
|
Assignee | ||
Comment 11•11 years ago
|
||
(In reply to Sören Hentzschel from comment #9) > Hi, > > out of sheer curiosity: what's the reason for the new/improved Firefox logo? > Is there an announcement or a newsgroup discussion or anything else you can > point me? > > Thanks! http://blog.seanmartell.com/2013/06/27/rebuilding-a-simplified-firefox-logo/
You need to log in
before you can comment on or make changes to this bug.
Description
•