Closed
Bug 884098
Opened 11 years ago
Closed 11 years ago
Remove back to top button from /tools and /guides
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cassie, Assigned: alicoding)
Details
(Whiteboard: designQA)
Attachments
(1 file)
This page isn't long enough to warrant a 'back to top' button.
|
Assignee | |
Comment 1•11 years ago
|
||
Could this be resolve using my patch? if they already on the top they wouldn't see that back to top button anyway and if they start scrolling then it will appear for the user. But if you think this should be completely remove I can send a patch to this bug.
|
Reporter | |
Comment 2•11 years ago
|
||
I would just remove it completely. It's not the kind of page that will have long scrolling content, so we don't need this functionality here at all.
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → ali
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Summary: Remove back to top button from /tools → Remove back to top button from /tools and /guides
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #764228 -
Flags: review?(dale)
|
||
Updated•11 years ago
|
Attachment #764228 -
Flags: review?(dale) → review+
|
||
Comment 4•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/8cda5a4b29bdf50155af0a16297a53758c9350b7 bug884098 - no back to top on some page https://github.com/mozilla/webmaker.org/commit/20105d735cb2d328f83fade39aa0f353e9e5e404 Merge pull request #174 from alicoding/bug884098 bug884098 - no back to top on some page
|
|
Assignee | |
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•