884520 - Do something with crash reports

Status: RESOLVED INCOMPLETE

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Jon Buckley [:jbuck]]

I no-oped the crash report last week, we should add it back.

Comment 1

[Matthew Schranz [:mjschranz]]

So we know we want to do this, but this ticket needs some sort of discussion/plan on what that is.

Comment 2

[David Humphrey (:humph)]

Personally, I think we should write a bower package for our Popcorn Maker crash reporter, remove the UI totally, and use it across all our apps so we get browser crash info for every failure.  Where this goes, I'm not sure.  We could easily make a new node.js app that accepts the reports.

Comment 3

[Jon Buckley [:jbuck]]

I think we should just use a hosted service that collects data and aggregates it for us. Let's not write code, especially if someone else has done a way better job.

Comment 4

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/416

Food for thought!

Comment 5

[Jon Buckley [:jbuck]]

If we don't want to go this route, due to concerns about privacy, we'll need to run our own instance of https://github.com/getsentry/sentry .

Comment 6

[Matthew Schranz [:mjschranz]]

I'm going to say don't disable the UI in the interim because I just landed a patch to make sure we backup user data on crashes. Granted this means they could have garbage data backed up now but there will be cases where it won't necessarily cause a crash again immediately. Either that or just configure the the crash reporter to only hide the UI rather than not function completely if turned off.

Comment 7

[David Humphrey (:humph)]

Comment on attachment 8361438 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/416

It breaks my heart, but r+

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/b3d9d30c9dab031ce1ea9469ea560bb47824624a
Bug 884520 - Disable crash reporter UI

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/7a07c2647e92a3356a64db347ab64719e513240b
Revert "Bug 884520 - Disable crash reporter UI"

This reverts commit b3d9d30c9dab031ce1ea9469ea560bb47824624a.

Comment 10

[Jon Buckley [:jbuck]]

Newrelic is now capturing our errors for us. Hooray!

I think we can have a patch to detect "We've gone into an error state. Reload the page, and we'll restore your project from back-up"

Comment 11

[Chris DeCairos (:cade)]

Popcorn Maker is no longer under active development.

https://learning.mozilla.org/blog/product-update-for-appmaker-and-popcorn-maker