884738 - leaks in JSM + Workers

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: mochitest

This mochitest reproduces the leak.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 764664 [details] [diff] [review]
mochitest

This is missing test_bug884738.js

Comment 3

[Andrea Marchesini [:baku]]

Attachment: mochi

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 765026 [details] [diff] [review]
mochi

This will definitely leak until shutdown but there's no gecko bug here really.

You're stashing functions that reference the window (e.g. "ok") inside event handlers on the worker. The worker is never going to go away (well, until shutdown) since it lives in a JSM.

Comment 5

[Andrea Marchesini [:baku]]

> This will definitely leak until shutdown but there's no gecko bug here
> really.

Ok. But this is not green on try because of this leak. We have the same problem in bug 883784.
Any idea how to fix it? or how to make it green on try? :)

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Andrea Marchesini (:baku) from comment #5)

In the JSM instead of doing 'this.worker' you could use 'let worker' in the start function. Then the worker can go away when it's done.

That's probably all you need. If it still gives you problems then you could try changing the import function in the xul file to import into a temporary local variable instead of the global scope.