884943 - Excessive (and erratic) whitespace under JS tables

Status: RESOLVED FIXED

(Webtools :: mediawiki-bugzilla, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

Recently someone turned on JS tables for mediawiki-bugzilla, which is great except sometimes the extension seems to generate an excessive amount of whitespace under tables.  This most often happens with empty tables (queries that have no results), but also occasionally happens with non-empty tables.

We most often see this on our Triage page:

  https://wiki.mozilla.org/Mobile/Triage

Comment 1

[Deb Richardson [:dria] (plz NEEDINFO)]

Any chance we could get this looked at soon?

Comment 2

[Lawrence Mandel [:lmandel] (use needinfo)]

dataTables_wrapper specifies "min-height: 302px;". Dropping this seems to fix the issue.

Comment 3

[Brandon Savage [:brandon]]

I've added a patch: https://github.com/mozilla/mediawiki-bugzilla/pull/38 :lmandel can you review?

Comment 4

[Brandon Savage [:brandon]]

:lmandel any chance you can review the above patch and we can get this landed soon?

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Sorry for the delay here. The patch looks good based on my comment 2. However, I have not had any time to test it. Brandon - Do you have this code running in a staging environment where I can easily test before granting an r+?

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

I tested the patch locally today. The change removes the white space under the table as desired. This change does have a side effect in that when using the paginate option to browse the issues, if the next page has fewer issues than the previous page the entire height of the wiki page will change as the table height changes causing a reflow. I think it would be preferable if this didn't happen but don't think this is a show stopper. r+

Brandon - Do you need me to somehow mark an r+ on Github?

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Any word on when we'll see this fix in production?