885131 - What to show when region isn't available

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P1)

Description

[Andy McKay]

We have two main API's we use:

get_price(region=...)
get_price_locale(region=...)

The first returns the price as a decimal. The second as a localised string with currency.

This is all fine. Until you submit an app that is for sale in Canada only. Then you view the app in the developer tools, fireplace or reviewer tools.

What do we do? Currently we error, because the app is not available in that region.

This is fine for consumer pages because we are addressing that in bug 878215.

But, for example, the reviewer tools call get_price in at least three different places.

Should we just fall back on None and make sure everywhere knows that None means "there should be a price but there is None". Would we then need a seperate API for reviewer tools and developer pages that they can call?

Comment 1

[Andy McKay]

How about:

app.get_price_tier()

Will return the price tier (object or price?). And stop the KeyError raising and just return None.

Then in all developer and reviewer tools, just use app.get_price_tier().

Comment 2

[Rob Hudson [:robhudson]]

I think showing price tier could make sense. Especially if we had some grid showing the price in various regions and where it is not available that we could readily link to.

Comment 3

[Andy McKay]

wip, needs tests writing and fixing https://github.com/andymckay/zamboni/commit/1fae94

Comment 4

[Andy McKay]

https://github.com/mozilla/zamboni/commit/d74a8c

Comment 5

[Andy McKay]

STR:

1. upload and setup a paid app, pick a tier
2. open the developer tools or reviewer tools for that app in a region that doesn't exist for that app, eg: ?region=br

Should not throw errors.

Comment 7

[krupa raj[:krupa]]

blocked on verification by  https://bugzilla.mozilla.org/show_bug.cgi?id=886713