88523 - [RFE] Autocomplete URLs in classic theme shouldn't have titles in italics

Status: VERIFIED FIXED

(SeaMonkey :: Themes, enhancement)

Description

[Nick Johnston]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.2) Gecko/20010628
BuildID:    2001062815

When I start typing in the address bar, Mozilla displays a number of matching
URLs. These URLs have the page's title displayed next to them *in italics*. 

The font used for the URL (on Win32) is MS Sans Serif, not a true type font. The
italics look horrible and make reading the title difficult (view screenshot at
supplied URL).

In addition, I don't see why the titles need to be emphasised in 
any way. I would simply put them in brackets, e.g.

http://slashdot.org/         (Slashdot, News for Nerds)

(Note I have ranked this as "Minor" rather than "Trivial", as it does reduce
Mozilla's usability)

Reproducible: Always
Steps to Reproduce:
1. Start typing the URL of a site in your history in the address bar.
2. When Mozilla displays a list of matches, note that the titles of the matches
URLs are displayed in italics.

Actual Results:  Site/page title displayed in italics.

Expected Results:  Title should be displayed in normal font, no need for
emphasis. If emphasis is required, bold rather than italic should be used.

Comment 1

[Francisco León]

Confirmed. I will put it up as a request for enhancement

Comment 2

[Alex Bishop]

This only occurs in the Classic theme, so I'm moving this to the Themes component.

I don't think the page titles need to appear in brackets. They could just appear
a little darker, as they do in the Modern theme.

Comment 3

[Alex Bishop]

Attachment: How Autocomplete page titles look in Modern (for comparison)

Comment 4

[Alex Bishop]

When I said the page titles could appear a little darker, I meant to say that
they should appear a little lighter.

Adding "classic" keyword and reassigning to default owner and QA for Themes.

Comment 5

[Francisco León]

Updating the summary a bit. I know we are using keyword classic, but this way
the bug can be easy to understand while doing queries

Comment 6

[Matthew T (active 1999-2002)]

This is a problem on Mac Classic too. --> All/All.

I don't think there's any good reason that the titles should be shown any 
differently from the URLs. Just being in a different column makes it obvious 
enough what they are.

Comment 7

[Joe Hewitt (gone)]

Mass reassigning some of my theme bugs to Shuehan.

Comment 8

[shliang]

Attachment: un-italicize titles

Comment 9

[shliang]

Attachment: doing this over

Comment 10

[jag (Peter Annema)]

Comment on attachment 55321 [details] [diff] [review]
doing this over

r=jag

Comment 11

[shliang]

Attachment: changing text color as well

Comment 12

[Joe Hewitt (gone)]

Comment on attachment 56344 [details] [diff] [review]
changing text color as well

sr=hewitt

Comment 13

[shliang]

checked in

Comment 14

[Patty Mac]

Verified the patch.