Closed Bug 885259 Opened 11 years ago Closed 11 years ago

[SMS/MMS] Edit mode can be enabled while composing a message

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:leo+, b2g18 verified, b2g18-v1.0.1 unaffected, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- verified
b2g18-v1.0.1 --- unaffected
b2g-v1.1hd --- fixed

People

(Reporter: isabelrios, Assigned: jugglinmike)

Details

(Keywords: regression, Whiteboard: MMS_TEF)

Attachments

(2 files)

edit and compose screens overlapped
33.48 KB, image/png
Details
Hide Compose field during edit
1.20 KB, patch
borjasalguero
: review+
Details | Diff | Splinter Review 
Unagi device, build:
Gecko-856e202
Gaia-aea6834

PROCEDURE
1. Start composing a message
2. Tap on intro several times, continue writing
3. Tap on edit button

EXPECTED
Edit mode should not be enabled while composing

ACTUAL
It is possible to edit while composing. The edit and compose screen are overlapped. 
Please see screenshots attached
Mike, I think you know this part better than us, could you help us on this? Thanks!!!
Flags: needinfo?(mike)
Is this a regression in 1.1? If not, not a blocker.
Andrew confirmed this is a regression.
blocking-b2g: leo? → leo+
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → unaffected
Keywords: regression
Patch on the way!
Assignee: nobody → mike
Flags: needinfo?(mike)
Although in comment 0, the "Expected" result is:

> Edit mode should not be enabled while composing

The interaction specification (version 8, page 17) and the visual specification (which has no version information) show that the "Edit" mode button is enabled while a message is being composed.

This patch aligns with the specifications: Edit Mode may be entered during message composition. With the patch applied, the Compose field will be completely hidden from view while in Edit mode.
Attachment #765950 - Flags: review?(fbsc)
Hi Borja,

I noticed this patch has been awaiting review for a few days. Would it be helpful if I requested review from someone else?
Comment on attachment 765950 [details] [diff] [review]
Hide Compose field during edit

Thanks for this surgical patch!
Attachment #765950 - Flags: review?(fbsc) → review+
Landed on `master` at commit 95e2583d41e3663f965f5935de3bb0f1c6210807

Thanks for the review, Borja!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted 95e2583d41e3663f965f5935de3bb0f1c6210807 to:
v1-train: 2063d5066073afd0a72b96ccd57847d371f57415
status-b2g18: affected → fixed
v1.1.0hd: 2063d5066073afd0a72b96ccd57847d371f57415
status-b2g-v1.1hd: --- → fixed
Verified with Unagi v1-train build:
Gecko-96c693c
Gaia-0d5a9a7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: