885630 - Setup b2g gonk-JB emulator builds for v1.2

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Michael Wu [:mwu]]

The 1.2 release will be based on gonk-JB. We want to make jb emulator builds in order to make sure people don't break the build. We'll also want tests at some point, but builds are a good first start. We'll want this running on m-c/m-i/birch.

Support for this isn't fully landed yet, but I'll post here once it's ready.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

found in triage

Comment 2

[Michael Wu [:mwu]]

The gonk-jb emulator is now available.

BRANCH=master ./config.sh emulator-jb && ./build.sh

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github PR for manifest

With changes in external/qemu, hardware/ril, devices/generic/goldfish merged, emulator test cases runs with JB Gonk!

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github PR for hardware/ril

In hardware/ril, ICS and JB share the same HEAD currently, so this PR is for master branch.

Comment 5

[Vicamo Yang [:vicamo][:vyang]]

Attachment: Github PR for device/generic/goldfish

This PR is basically merging current b2g master branch HEAD into a new branch named "b2g-4.2.2_r1".

Comment 6

[Vicamo Yang [:vicamo][:vyang]]

There is already a merge branch named "b2g-4.2.2_r1" waiting for JB Gonk in external/qemu.  See https://github.com/mozilla-b2g/platform_external_qemu/tree/b2g-4.2.2_r1 .  It's simply renamed from "next/jb-mr1-release" branch.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 771974 [details]
Github PR for hardware/ril

Merged. I would prefer a different bug next time though, as this bug is a releng bug just to make gonk-jb builds. It does not require successful test runs.

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 771973 [details]
Github PR for manifest

Merged

Comment 9

[Chris AtLee [:catlee]]

do we need debug builds as well?

Comment 10

[Chris AtLee [:catlee]]

Is there a reason the name for the "gecko.git" repo has been changed to be "mozilla-central" for the base-jb.xml manifest? 

https://github.com/mozilla-b2g/b2g-manifest/blob/master/base-jb.xml#L13

This is breaking our build scripts, which currently assume that the gecko repo is named "gecko.git" in the manifest.

Comment 11

[Chris AtLee [:catlee]]

Also, is there a reason why the manifests point to the AOSP mirrors rather than CAF for projects like platform/abi/cpp, platform/bionic and platform/bootable/recovery?

Comment 12

[Chris AtLee [:catlee]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/91#attch-to-bugzilla

Pointer to Github pull-request

Comment 13

[Michael Wu [:mwu]]

Comment on attachment 790314 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/b2g-manifest/pull/91#attch-to-bugzilla

Looks good. If you don't mind, please do an interactive rebase and squash everything into one commit before merging.

Comment 14

[Chris AtLee [:catlee]]

Looks like the github PR got merged as-is.

Comment 15

[Chris AtLee [:catlee]]

Attachment: master-b2g-manifest.diff

Two small follow up issues.

First, we need to change gaia's remote to be mozilla like for gecko.

Second, CAF's mirror of icu4c is missing the android-4.3_r2.1 tag for some reason. All the other repositories seem to have it. We can pull just this repo from aosp (or linaro) and start mirroring it from aosp. Alternatively, it appears as though the linaro mirror of icu4c does have the correct tag, and we already have that mirrored, so we could use that instead.

Comment 16

[Michael Wu [:mwu]]

Comment on attachment 794672 [details] [diff] [review]
master-b2g-manifest.diff

Review of attachment 794672 [details] [diff] [review]:
-----------------------------------------------------------------

::: base-jb.xml
@@ +56,5 @@
>    <project name="platform/external/giflib" path="external/giflib"/>
>    <project name="platform/external/gtest" path="external/gtest"/>
>    <project name="platform/external/harfbuzz" path="external/harfbuzz"/>
>    <project name="platform/external/harfbuzz_ng" path="external/harfbuzz_ng"/>
> +  <project name="platform/external/icu4c" path="external/icu4c" remote="aosp"/>

Let's not change remotes here. Just point to the same commit that the android-4.3_r2.1 tag points to.

Comment 17

[Chris AtLee [:catlee]]

Attachment: move gaia to git.mozilla.org; force icu4c's revision

Comment 18

[Chris AtLee [:catlee]]

Status update: new manifests look like they're working well. I was running into issues last week because of missing build dependencies for libsuspend.

Seem to have gotten past that now, but now builds are failing because of xmllint being missing.

Comment 19

[Chris AtLee [:catlee]]

...and now busted again because of new base-jb.xml manifest :\

Comment 20

[Chris AtLee [:catlee]]

Attachment: gecko configs for emulator-jb

Comment 21

[Chris AtLee [:catlee]]

Attachment: remove gecko/gaia from manifest by path rather than by name

the base-jb.xml manifest uses name="gaia" for gaia, whereas other manifest use name="gaia.git". Rather than forcing all manifests to use consistent naming, I change b2g_build to look at the target path on disk, and remove projects from the manifest based on that.

Comment 22

[Chris AtLee [:catlee]]

Attachment: gecko configs for emulator-jb

same as before except the addition of "upload_platform"

Comment 23

[Chris AtLee [:catlee]]

Attachment: remove gecko/gaia from manifest by path rather than by name; use upload_platform for manifest upload

same as before, except I modified upload_source_manifest to obey the gecko config's upload_platform

Comment 24

[Chris AtLee [:catlee]]

Attachment: buildbot-configs for emulator-jb

Comment 25

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/540c53908079

Comment 26

[John Hopkins (:jhopkins)]

In production.

Comment 27

[Armen [:armenzg]]

Merged to production branch. Live in production.