885647 - Wi-Fi is enabling automatically after every reboot / airplane mode on-off even after disabling it.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[vasanth]

Attachment: wifi.suspended is not inverse of wifi.enabled

1. In system app airplane_mode.js, during boot up/airplane mode off, 
wifi.suspended is used to restore wifi.enabled value

2. But in settings app wifi.js, it's assumed that wifi.suspended is !wifi.enabled


So in settings app, when wifi is turned off, wifi.suspended becomes true.
After reboot, wifi.suspended is used to restore wifi.enabled.
Since wifi.suspended is true, wifi is enabled again.

Attached patch fixes that issue.

Thanks,
Vasanth

Comment 1

[Michael Vines [:m1] [:evilmachines]]

Can you please attach the .patch file directly to the bug?

Comment 2

[vasanth]

Attachment: wifi.suspended is not inverse of wifi.enabled

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

vasanth,

After the patch is uploaded, you need to request review to module owner, in this case, it should be :kaze or evelyn huang.

Comment 4

[Alex Keybl [:akeybl]]

We don't feel strongly either way about this bug, so we'll leave it to partners to decide. Looping in UX to figure out expected behavior here.

Comment 5

[Fabien Cazenave [:kaze]]

Comment on attachment 765794 [details] [diff] [review]
wifi.suspended is not inverse of wifi.enabled

Thank you vasanth for catching this. Your patch makes perfect sense to me: if wi-fi is disabled, I don’t see why it should be enabled when turning the airplane mode on and off again, or when rebooting the device.

If UX wasn’t NI’ed I’d have merged it already. :-)
Pinging Fernando in case he has anything to object, as he wrote the related lines in wifi.js.

Comment 6

[Stephany Wilkes]

Adding Casey to needinfo even though this is not blocking. Blockers still get priority.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 765794 [details] [diff] [review]
wifi.suspended is not inverse of wifi.enabled

Review of attachment 765794 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me. Thanks!

Comment 8

[vasanth]

Thanks Fabian Cazenave and Fernando. Can we get to the closure of this?

Comment 9

[Fabien Cazenave [:kaze]]

Merged on master (I’m pretty sure UX will be OK… Casey, kick me if I’m wrong):
https://github.com/mozilla-b2g/gaia/commit/16a53406188b5b0819535b434d24dba4c0329c12

Comment 10

[Casey Yee]

It's fine :)  thanks for the fix folks.