885813 - A specific youtube clip ends before it says it ends

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

Something about this clip causes it to end early.

http://www.youtube.com/watch?v=swT1uSSUVUc

You can see it in both popcorn maker and on youtube's own page.

Seems like duration data is reporting a number that is after the ended event.

This is a good reproducible link and I am glad I found it. It exposes a bug I have not been able to reproduce before.

Comment 1

[Scott [:thecount] Downe]

I don't think we can solve this in a good way on our end.

I filed it here in hopes at the least, more info, at the most a fix: http://code.google.com/p/gdata-issues/issues/detail?id=4807&thanks=4807&ts=1372174729

What I can tell you is that the youtube wrapper thinks it has ended before the reported duration is hit. When we try to sequence these and line them up, we use the duration data to know when it is going to end. If it is wrong there is no way we can reliably sequence up.

Let's see if the bug I filed shakes anything out before I add a hack.

Keep in mind this problem is also before it hits sequencer. We emulate html with our youtube wrapper, so an ended event is a real thing, and it also has expected functionality, which is to end the video and fire a paused event if loop is false.

An ended event doesn't mean anything in a sequence, we should keep playing. We cover this by not letting the sequence track event to be greater than the reported duration, just equal to. It never actually ends.

I can add a hack that, from inside the seqencer, if I ever hit an ended event in a sequence and we were playing, to play again. There would be a noticable blip, though.

Comment 2

[Scott [:thecount] Downe]

I think I have a handle on this now.

I prototyped it yesterday and got it working.

Needs a fix in the YouTube wrapper first.

Filed and fixed it here: bug 890068

Comment 3

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/96

Comment 4

[Scott [:thecount] Downe]

When you test this, take a moment to test bug 889848 with this patch, I did, and it's fixing it on my end.

Comment 5

[Matthew Schranz [:mjschranz]]

Comment on attachment 772086 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/96

R+ with review comments addressed.

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 772086 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/96

Updated.

Might as well take another quick look.

Comment 7

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/9b2938914e400c1ac117f876373a4cdf6d563b99