886209 - SeaMonkey Builders don't know about SHT_ARM_EXIDX

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Justin Wood (:Callek)]

Attachment: [mozilla-central] v1

SeaMonkey, building on CentOS 5.x does not seem to know about SHT_ARM_EXIDX.

Per :glandium this patch should fix us, and is acceptable.

Build log below:

make[7]: Entering directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/toolkit/components/autocomplete'
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o nsAutoCompleteController.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DMOZ_SUITE=1 -DNO_NSPR_10_SUPPORT  -I/builds/slave/c-cen-t-lnx/build/mozilla/toolkit/components/autocomplete -I. -I../../../dist/include  -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nss      -fPIC  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer    -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsAutoCompleteController.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/toolkit/components/autocomplete/nsAutoCompleteController.cpp
nsAutoCompleteSimpleResult.cpp
/usr/bin/ccache /tools/gcc-4.5/bin/g++ -o nsAutoCompleteSimpleResult.o -c -I../../../dist/stl_wrappers -I../../../dist/system_wrappers -include /builds/slave/c-cen-t-lnx/build/mozilla/config/gcc_hidden.h -DMOZ_GLUE_IN_PROGRAM -DXPCOM_TRANSLATE_NSGM_ENTRY_POINT=1 -DMOZILLA_INTERNAL_API -D_IMPL_NS_COM -DEXPORT_XPT_API -DEXPORT_XPTC_API -D_IMPL_NS_GFX -D_IMPL_NS_WIDGET -DIMPL_XREAPI -DIMPL_NS_NET -DIMPL_THEBES  -DSTATIC_EXPORTABLE_JS_API -DMOZ_SUITE=1 -DNO_NSPR_10_SUPPORT  -I/builds/slave/c-cen-t-lnx/build/mozilla/toolkit/components/autocomplete -I. -I../../../dist/include  -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nspr -I/builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/include/nss      -fPIC  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -gdwarf-2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -fno-tree-vrp -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fomit-frame-pointer    -DMOZILLA_CLIENT -include ../../../mozilla-config.h -MD -MP -MF .deps/nsAutoCompleteSimpleResult.o.pp  /builds/slave/c-cen-t-lnx/build/mozilla/toolkit/components/autocomplete/nsAutoCompleteSimpleResult.cpp
nsIAutoCompleteController.idl
/builds/slave/c-cen-t-lnx/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/config/pythonpath.py \
	  -I/builds/slave/c-cen-t-lnx/build/mozilla/other-licenses/ply \
	  -I/builds/slave/c-cen-t-lnx/build/mozilla/xpcom/typelib/xpt/tools \
	  /builds/slave/c-cen-t-lnx/build/objdir/mozilla/dist/sdk/bin/typelib.py -I/builds/slave/c-cen-t-lnx/build/mozilla/toolkit/components/autocomplete -I../../../dist/idl /builds/slave/c-cen-t-lnx/build/mozilla/toolkit/components/autocomplete/nsIAutoCompleteController.idl -d .deps/nsIAutoCompleteController.xpt.pp -o _xpidlgen/nsIAutoCompleteController.xpt
nsIAutoCompleteInput.idl
../../../../../../../mozilla/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc: In function ‘bool<unnamed>::LoadSymbols(const std::string&, bool, const typename ElfClass::Ehdr*, bool, <unnamed>::LoadSymbolsInfo<ElfClass>*, SymbolData, google_breakpad::Module*)’:
../../../../../../../mozilla/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc:690:52: error: ‘SHT_ARM_EXIDX’ was not declared in this scope
make[7]: *** [linux/dump_symbols.o] Error 1
make[7]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/toolkit/crashreporter/google-breakpad/src/common'
make[6]: *** [libs] Error 2
make[6]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/mozilla/toolkit/crashreporter'
make[5]: *** [crashreporter_libs] Error 2

Comment 1

[Mike Hommey [:glandium]]

Comment on attachment 766522 [details] [diff] [review]
[mozilla-central] v1

Review of attachment 766522 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/crashreporter/breakpad-patches/12-sht-arm-exidx-define.patch
@@ +7,5 @@
> +(fixes SeaMonkey building on CentOS5.x)
> +
> +diff --git a/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc b/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc
> +--- a/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc
> ++++ b/toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc

Path needs to be relative to toolkit/crashreporter/google-breakpad, i.e. a/src/common/...

::: toolkit/crashreporter/google-breakpad/src/common/linux/dump_symbols.cc
@@ +71,4 @@
>  #include "common/using_std_string.h"
>  #include "common/logging.h"
>  
> +#ifndef SHT_ARM_EXIDX

Can you add a comment that older glibc and bionic don't define it?

Comment 2

[Justin Wood (:Callek)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79194143ec89

With path changes to the 11-* patch as well, with rs+=glandium over IRC.

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/79194143ec89

Comment 4

[Ed Morley [:emorley]]

This landed on mozilla-central whilst it was still mozilla24, however mcMerge references the bugzilla target milestone field ordering, which was updated pre-emptively before the merge had occurred.