886608 - Add basic wrappers around 'adb forward' and 'adb remount' to dmADB

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

We need to run some commands like 'adb remount' and 'adb forward' when setting up b2g unittests. DevicemanagerADB should make it easier for us to do so.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - add remount, forward and devices methods to dmADB

Comment 2

[William Lachance (:wlach)]

Comment on attachment 767298 [details] [diff] [review]
Patch 1.0 - add remount, forward and devices methods to dmADB

Review of attachment 767298 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good except for some minor documentation issues. r+ with those addressed.

::: mozdevice/mozdevice/devicemanagerADB.py
@@ +157,5 @@
>          return None
>  
> +    def forward(self, local, remote):
> +        """
> +        Forward socket connections, forward specs are one of:

This line should just say "forward socket connection.". Put "Forward specs are one of:" two lines down.

@@ +168,5 @@
> +        """
> +        return self._checkCmd(['forward', local, remote])
> +
> +    def remount(self):
> +        "Remounts the /system partition on the device read-write"

Please end this docstring with a period.

@@ +172,5 @@
> +        "Remounts the /system partition on the device read-write"
> +        return self._checkCmd(['remount'])
> +
> +    def devices(self):
> +        "Return a list of connected devices as (serial, status) tuples"

Please end this docstring with a period.

Comment 3

[Andrew Halberstadt [:ahal]]

https://github.com/mozilla/mozbase/commit/e5dfee56018ca57d06b67b8a32e1883f8f238b7c

Comment 4

[Andrew Halberstadt [:ahal]]

Did a follow up push to update the sphinx docs:
https://github.com/mozilla/mozbase/commit/b39204c7b2414c54c6bd701cfee5a45b613cb0ae