Closed
Bug 887081
Opened 11 years ago
Closed 11 years ago
healthreporter.jsm should properly export objects by attaching them to the global object
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: smirea, Assigned: smirea)
Details
(Whiteboard: [qa-])
Attachments
(2 files)
1.29 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
1.58 KB,
patch
|
Details | Diff | Splinter Review |
Currently HealthReporter is defined as a plain function and while this works on the desktop version for now, due to structural changes, it causes issues on other platforms (most notably Boot2Gecko). All exported objects in that file should be attached to the global object
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → steven.mirea
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #767524 -
Flags: review?(gps)
Assignee | ||
Updated•11 years ago
|
Summary: healthreporter.jsm shoud properly export files by attaching them to the global object → healthreporter.jsm shoud properly export objects by attaching them to the global object
Comment 2•11 years ago
|
||
Comment on attachment 767524 [details] [diff] [review] attached HealthReporter to the global object Add checkin-needed to the bug keywords and magic happens.
Attachment #767524 -
Flags: review?(gps) → review+
Comment 3•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #2) > Add checkin-needed to the bug keywords and magic happens. Not if the patch doesn't have hg headers. https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Summary: healthreporter.jsm shoud properly export objects by attaching them to the global object → healthreporter.jsm should properly export objects by attaching them to the global object
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 767524 [details] [diff] [review] attached HealthReporter to the global object # HG changeset patch # User Stefan Mirea <smirea@mozilla.org> # Date 1378479287 25200 # Fri Sep 06 07:54:47 2013 -0700 # Node ID 9e6ac64d9c25cbdf3f07eb977490bf45f9ed6afb # Parent 4b5789932294d850b002b41a01564596dbcf54da Bug 887081 - healthreporter.jsm should export objects to the global object;r=gps >diff --git a/services/healthreport/healthreporter.jsm b/services/healthreport/healthreporter.jsm >--- a/services/healthreport/healthreporter.jsm >+++ b/services/healthreport/healthreporter.jsm >@@ -1137,33 +1137,33 @@ AbstractHealthReporter.prototype = Objec > * > * @param branch > * (string) The preferences branch to use for state storage. The value > * must end with a period (.). > * > * @param policy > * (HealthReportPolicy) Policy driving execution of HealthReporter. > */ >-function HealthReporter(branch, policy, sessionRecorder, stateLeaf=null) { >+this.HealthReporter = function (branch, policy, sessionRecorder, stateLeaf=null) { > this._stateLeaf = stateLeaf; > > AbstractHealthReporter.call(this, branch, policy, sessionRecorder); > > if (!this.serverURI) { > throw new Error("No server URI defined. Did you forget to define the pref?"); > } > > if (!this.serverNamespace) { > throw new Error("No server namespace defined. Did you forget a pref?"); > } > > this._state = new HealthReporterState(this); > } > >-HealthReporter.prototype = Object.freeze({ >+this.HealthReporter.prototype = Object.freeze({ > __proto__: AbstractHealthReporter.prototype, > > QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver]), > > get lastSubmitID() { > return this._state.lastSubmitID; > }, >
Assignee | ||
Comment 5•11 years ago
|
||
Had to resubmit in order to attach HG headers. nothing else has changed.
Attachment #800816 -
Flags: review?(gps)
Comment 6•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/34aeae66ccd4
Whiteboard: [fixed in fx-team][qa-]
Target Milestone: --- → Firefox 26
Updated•11 years ago
|
Attachment #800816 -
Flags: review?(gps)
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/34aeae66ccd4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team][qa-] → [qa-]
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•