887236 - prefix the current events in workers with "Worker"

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

...the same way as what we have in the main thread.
That way we can start using the real DOM events in workers without any hacks in them.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=b81f1f6c9fc4

This is regression risky, but I don't know how else to deal with this.
Eventually all the events should be DOM events ofc.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I wouldn't worry too much about this breaking things. I don't think these interfaceobjects are used terribly much. Though it would be good to land this early in a cycle and then hope that a lot of the followup patches to use more xpcom Events in workers can land in the same cycle.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/794da9907814

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/794da9907814

Comment 5

[Kohei Yoshino [:kohei]]

Added: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/25/Site_Compatibility

Comment 6

[Jean-Yves Perrier [:teoli]]

I switched back the doc flag as there much more doc needed for this bug: we need to actually document WorkerEvent and co :-)

BTW, I wasn't able to find the spec where these interfaces are specified. Anybody knows about it?

Thanks in advance.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We shouldn't document the Worker* variants, IMO. They're broken versions of the Event interfaces, only exposed to workers; they're being renamed because we're going to implement the correct main-thread implementations to workers.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

There are Worker* events also in the main thread, in case events are dispatched to main thread Worker.
But yes, all the Worker* events are just temporary and we're trying to get rid of them asap.

Comment 9

[Jean-Yves Perrier [:teoli]]

So I switch back to dev-doc-complete :-) Thanks for the explanation!

Comment 10

[Masatoshi Kimura [:emk]]

I think the site-compat doc should explain that the change is temporary.

Comment 11

[Kohei Yoshino [:kohei]]

Fixed the description in the compatibility doc.

Comment 12

[Florian Bender]

Can you please point me to the bug that undoes the change?

Comment 13

[Masatoshi Kimura [:emk]]

Filed bug 921485.

Comment 14

[Masatoshi Kimura [:emk]]

The temporary "Worker" prefix was removed again by bug 928312.

Comment 15

[Kohei Yoshino [:kohei]]

(In reply to Masatoshi Kimura [:emk] from comment #14)
> The temporary "Worker" prefix was removed again by bug 928312.

OK, will add a note to the 28 compat doc :)