887621 - Defect - Bookmark & Pin states are not changing when selected

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: App Bar, defect, P2)

Description

[Kamil Jozwiak [:kjozwiak]]

When selecting either the "Star" or "Pin" button on the "Navigation App Bar", the states will not change making it almost impossible to know if the website has been bookmarked or pinned.

Steps to reproduce the issue:

1) Open Firefox Metro
2) Go to mozilla.org
3) Once the website has been loaded, select the "Star" button (notice that the state has not been changed but has been added to bookmarks)
4) If you return to the website, you will have no indication that the website has been bookmarked ("Star" still appears as unselected)

You can reproduce the same issue with the "Pin" following the same steps but selecting the "Pin" icon

Current Behavior:

- Both the "Star" and "Pin" buttons are not changing states when selecting them, making it difficult to know what website is Bookmarked/Pinned

Expected Behavior:

- There should be some indication that the website is either Bookmarked or Pinned

Comment 1

[Jim Mathies [:jimm]]

Attachment: fix

We are missing the state for [checked].

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 768507 [details] [diff] [review]
fix

Review of attachment 768507 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/tests/mochitest/browser_context_ui.js
@@ +38,5 @@
>      // sanity check - toggle on again
>      doEdgeUIGesture();
>      is(ContextUI.navbarVisible, true, "Navbar is still visible after third swipe");
>      is(ContextUI.tabbarVisible, true, "Tabbar is visible after third swipe");
> +    is(ContextUI.appbarVisible, false, "Appbar is hidden after third swipe");

Ignore this, it's supposed to be in the patch below this one in my queue.

Comment 3

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6fcd986f86ed

Thanks!

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6fcd986f86ed

Comment 5

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:25.0) Gecko/20130715 Firefox/25.0

Verified this fix on the latest nightly build using the steps provided in Description 
The "Star" and "Pin" buttons are now changing states when selected.

Comment 6

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #12 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-20-03-02-06-mozilla-central/

For the both the "Pin" & "Bookmark" buttons, went through the following test cases:

- Went through the original test case in comment #0 without any issues
- Tapped/Untapped and ensured that the states are being changed correctly
- Tapped, created a new tab and then returned to ensure that the correct state is being used
- Ensured that when tapping on websites from "Bookmarks", that the correct state is being used
- Went back and forth between pages using the "Back/Forward" buttons and ensured that the correct states are being used
- Tapped and then slide the Navigation App Bar down, then swiped it back in and ensured that the correct state is being used
- Used all of the above test cases in filled view without any issues