Closed Bug 887777 Opened 11 years ago Closed 11 years ago

Add unit tests for the suggestions

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: janjongboom, Assigned: janjongboom)

Details

Attachments

(1 file)

Pointer to pull request
46 bytes, patch
Details | Diff | Splinter Review 
We don't have any test coverage for the suggestions part of latin.js. Let's do that.
This adds some structure to the keyboard suggestions where we can add some more tests in the future. It mocks the worker and has a simple interface to talk to the IM.

The extra lines in latin.js are there because we had an undefined global hanging around that we crashed upon in tests.
Assignee: nobody → janjongboom
Attachment #768282 - Flags: review?(rlu)
Also added a test file for the workers, didn't write any useful tests, but please use it as a framework for building upon.
Attachment #768282 - Flags: review?(rlu) → review?(dflanagan)
Jan,

Thanks for these test cases. I won't have time to review before my vacation, however. I'll be back on 7/19.  Feel free to reassign the review if you'd like to get this landed before then.
Attachment #768282 - Flags: review?(dflanagan) → review?(rlu)
Superseeded by bug 803189.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: