887809 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners.

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alexandre Poirot [:ochameau]]

While working on 817580, I realized that we weren't nullifying this.consoleProgressListener during stopListeners request.
It ends up preventing reusing webconsole actor more than once.
(it will duplicate most console message on each new console actor instance)

Patch coming.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: b2g18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 768309 [details] [diff] [review]
b2g18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Thanks for the bug report and for the patch! Good find!

LocationChange tracking has been removed in Firefox 20, in bug 792062.

I think you can just add one liner:

  this.consoleProgressListener = null;

in the case for FileActivity.

Comment 3

[Alexandre Poirot [:ochameau]]

Actually I'm targeting gecko18 branch.
I still dream to uplift to 18, but I also want to use same actors fixes for the simulator, which uses gecko18 branch...

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 768409 [details] [diff] [review]
master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

I don't know how to manage the 18 story,
so here is a patch for master.

Comment 6

[Mihai Sucan [:msucan]]

Comment on attachment 768409 [details] [diff] [review]
master - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Thanks!

Comment 7

[Mihai Sucan [:msucan]]

Is this patch important for b2g18?

Comment 8

[Alexandre Poirot [:ochameau]]

It is important mainly if we want to land remote app actors also on 18.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ba0760ec608

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5ba0760ec608

Comment 11

[Alexandre Poirot [:ochameau]]

Attachment: b2g-18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Comment 12

[Alexandre Poirot [:ochameau]]

Comment on attachment 771315 [details] [diff] [review]
b2g-18 - webconsole actor doesn't unregister correctly consoleProgressListener on stopListeners

Rebased patch for b2g18.