887970 - TEST-UNEXPECTED-FAIL | tests/test-tabs.testTitleForDataURI | data: title is not Connecting... ("data:text/html;charset=utf-8,default" != "tab")

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I retriggered the 32-bit linux test runs a bunch of times to see how frequently bug 882867 is happening, and then this new test failure showed up a few times...

TEST-START | tests/test-tabs.testTitleForDataURI
TEST-UNEXPECTED-FAIL | tests/test-tabs.testTitleForDataURI | data: title is not Connecting... ("data:text/html;charset=utf-8,default" != "tab")
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/tabs/tab-firefox.js", line 98, in _onReady
    this._emit(EVENTS.ready.name, this._public);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/windows/tabs-firefox.js", line 128, in _emitEvent
    tabs._emit.apply(tabs, args);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 123, in _emit
    return this._emitOnObject.apply(this, args);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/deprecated/events.js", line 153, in _emitOnObject
    listener.apply(targetObj, params);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path.tests/tabs/test-firefox-tabs.js", line 50, in onReady
    test.assertEqual(tab.title, "tab", "data: title is not Connecting...");
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 189, in assertEqual
    this.fail(message);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.7ebd89a8-d8c9-4276-a73f-4e7971a364c8-at-jetpack.commonjs.path/sdk/test/harness.js", line 523, in testMessage
    this.trace();
TEST-END | tests/test-tabs.testTitleForDataURI

Comment 1

[Ed Morley [:emorley]]

Adding keyword so this shows up on TBPL :-)

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1070

Pointer to Github pull-request

Comment 3

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=24788642&tree=Jetpack
jetpack-mozilla-central-ubuntu32_vm-opt on 2013-07-01 09:37:20
revision: 20a541ce5c04
slave: tst-linux32-ec2-097

TEST-UNEXPECTED-FAIL | tests/test-tabs.testTitleForDataURI | data: title is not Connecting... ("data:text/html;charset=utf-8,default" != "tab")

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/bca91ba32f277ac97954e6b906c2304b09770b3f
Bug 887970: fixing tests/test-tabs.testTitleForDataURI and an unstable test that runs before it

https://github.com/mozilla/addon-sdk/commit/da0d2ef900e99c582e464601ccc6e8eb03e9898a
Merge pull request #1070 from erikvold/887970

Bug 887970: fixing tests/test-tabs.testTitleForDataURI and an unstable test that runs before it. r=Mossop

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 769553 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1070

I think testTabsIteratorAndLength also has an issue, but let's see how this helps.