888079 - control debugger start behind a pref, control debugger port with pref

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Allison Naaktgeboren :ally]

followup from 886546

Comment 1

[Allison Naaktgeboren :ally]

Attachment: wip

- wip, code complete.
-has debug code in it, untested due a startup issue that I can't see due to bug 888073

Comment 2

[Allison Naaktgeboren :ally]

Attachment: pref listeners

Talked to devtools about what is expected when port is changed. Currently on desktop they kill the server & force the user to restart the browser. Here, I kill and restart the server in that case.

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 770356 [details] [diff] [review]
pref listeners

Since you use 'devtools.debugger.remote-enabled' and 'devtools.debugger.remote-port' multiple times, I'd suggest making them consts at the top of the file.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 770356 [details] [diff] [review]
pref listeners

Review of attachment 770356 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser-ui.js
@@ +194,4 @@
>    },
>  
> +/************************************
> + * Devtools Debugger

nit - your spacing is off on this comment.

Comment 5

[Allison Naaktgeboren :ally]

Attachment: pref listeners with nits [checkin this one]

hg.m.o bustage

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/04c800fb45a6

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to :Ally Naaktgeboren from comment #2)
> Talked to devtools about what is expected when port is changed. Currently on
> desktop they kill the server & force the user to restart the browser. Here,
> I kill and restart the server in that case.

Actually what happens on desktop Firefox is that the port change is ignored, until a new server instance is started, which will use the new setting. Killing the server would severe any existing connections, which is something that we don't handle well currently, and is IMHO rather heavy-handed for an obscure pref change.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/04c800fb45a6