Closed
Bug 888573
Opened 11 years ago
Closed 11 years ago
Remove bit_cast
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file)
|
5.43 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Now we have BitwiseCast, we might as well use that.
Attachment #769328 -
Flags: review?(jwalden+bmo)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 769328 [details] [diff] [review] Patch v1 Review of attachment 769328 [details] [diff] [review]: ----------------------------------------------------------------- Hmm. Reading the comments in the code you're removing, I find myself wondering if we shouldn't be using memcpy or something here, to actually be strict-aliasing-safe. Internet is inconclusive but suggests the current pattern is standards-violating but tends to work nonetheless (and with gcc is guaranteed to work). Meh, I guess we can do something else later if this ever breaks. I'm a little surprised we're making changes to ipc/chromium code that are purely gardening, and not in pursuit of fixing some actual bug. Are you sure that's okay?
Attachment #769328 -
Flags: review?(jwalden+bmo) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/236b0583fb18
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•