888631 - Translations get all English tags on Save

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Localization, defect)

Description

[Thierry Régagnon]

What did you do?
================
1. Edit a translation
2. Write some (translated) tags for the page
3. Save your modifications

What happened?
==============
When the translation is saved, if you look at the tags for the page, you see your tags + all the English tags.

What should have happened?
==========================
We should only have the tags defined by the user in the translation interface. 

Is there anything else we should know?
======================================

Comment 1

[John Karahalis [:openjck]]

Thierry, Jeremie: Do you think this issue would be solved if we closed bug 671721?

Comment 2

[Thierry Régagnon]

(In reply to John Karahalis [:openjck] from comment #1)

I think we have here a bug (or undocumented feature?) recently introduced.

I think making tags localizable is great (bug 671721). But we also need to create our own tags (e.g. to mark incomplete translations).

Making tags localizable raises some questions. If a tag is removed on the original article, would it also be removed on the translation? 
Could we accept only a subset of the tags from the original article, for the translation?
This is a new feature that need some specification work.

Jeremie, what do you think?

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/03badd9580144a9765fe888b9a4acd00c87b1445
fix bug 888631 - Prevent translations from getting English tags

https://github.com/mozilla/kuma/commit/b1ee68ddc5dcb5f2eeeee50d29b223ad9f13058e
Merge pull request #1203 from darkwing/translations-tags-888631

fix bug 888631 - Prevent translations from getting English tags