88883 - Advanced Edit: Font element cannot contain events

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[rubydoo123]

the Advanced edit for FONT needs to have event choices removed from events tab

Comment 1

[Charles Manske]

No JS events at all? This is a new rule. Are there any other elements that
can't have any events?
We should simply disable the JS tab in this case.

Comment 2

[Charles Manske]

*** Bug 88945 has been marked as a duplicate of this bug. ***

Comment 3

[Charles Manske]

*** Bug 88925 has been marked as a duplicate of this bug. ***

Comment 4

[Charles Manske]

*** Bug 89448 has been marked as a duplicate of this bug. ***

Comment 5

[Charles Manske]

Expanding this bug to cover all elements that shouldn't have JS events

Comment 6

[Charles Manske]

Fixed by adding a new signal string to tell us not to allow editing JS Events
Add this code to EdAEJSAttributes.js in the method BuildJSEAttributeNameList():

+      // Since we don't allow user-editable JS events yet (but we will soon)
+      // simply remove the JS tab to not allow adding JS events
+      if (attNames[0] == "noJSEvents")
+      {
+        var tab = document.getElementById("tabJSE");
+        if (tab)
+          tab.parentNode.removeChild(tab);
+
+        return;
+      }
... 
-  // Always add core JS events
+  // Always add core JS events unless we aborted above
(rest is the same as before)

In EdAEAttributes.js, add this to tell us what elements to not set events on:
+
+// Elements that don't have core JSEvents:
+gJSAttr.font =
+[
+
"noJSEvents"
+];
+
+gJSAttr.applet =
+[
+
"noJSEvents"
+];
+
+gJSAttr.isindex =
+[
+
"noJSEvents"
+];
+
+gJSAttr.iframe =
+[
+
"noJSEvents"
+];

 

Comment 7

[Charles Manske]

Hmm, that diff is confused by tab characters in the source. The new element
entries look like this using 2 spaces instead of tabs:

// Elements that don't have JSEvents:
gJSAttr.font =
[
  "noJSEvents"
];

gJSAttr.applet =
[
  "noJSEvents"
];

gJSAttr.isindex =
[
  "noJSEvents"
];

gJSAttr.iframe =
[
  "noJSEvents"
];

Comment 8

[Charles Manske]

Fixed with other Advanced Editor dialog fixes last week.

Comment 9

[James Baxter]

Verified on 8-30 Build