Closed
Bug 888853
Opened 11 years ago
Closed 11 years ago
Enhance controller.restartApllication() to handle custom restart flags
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: andrei, Assigned: andrei)
References
Details
Attachments
(1 file)
2.67 KB,
patch
|
davehunt
:
feedback+
|
Details | Diff | Splinter Review |
For bug 886811 we need to send a custom restart type for some tests (mainly OSX restartChangeArchitecture tests) in controller.restartApplication() The method should be able to receive a new argument with a custom restart type, and default to what it uses now.
Assignee | ||
Updated•11 years ago
|
Summary: Enhance controller.restartApllication() to handle custom restart types → Enhance controller.restartApllication() to handle custom restart falgs
Assignee | ||
Comment 1•11 years ago
|
||
I need this for bug 886811 to be able to send custom restart flags for the OSX restartChangeArchitecture tests. We used to do a startUserShutdown() then do a custom restart. When we change that to restartApplication() we need to be able to specify those custom restart flags. I am not sure that this would be the right approach. A testrun (no new failures) http://mozmill-crowd.blargon7.com/#/functional/report/a1b02004612785c13cf7c6bf1e69e99d
Attachment #770147 -
Flags: feedback?(hskupin)
Attachment #770147 -
Flags: feedback?(dave.hunt)
Updated•11 years ago
|
Summary: Enhance controller.restartApllication() to handle custom restart falgs → Enhance controller.restartApllication() to handle custom restart flags
Comment 2•11 years ago
|
||
Comment on attachment 770147 [details] [diff] [review] patch v1 Review of attachment 770147 [details] [diff] [review]: ----------------------------------------------------------------- This approach looks good to me. I'll probably defer to Henrik for the final review though. ::: mozmill/mozmill/extension/resource/driver/controller.js @@ +429,5 @@ > + * Bitwise flag on how to do a shutdown. See: > + * https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIAppStartup#Constants > + */ > +MozMillController.prototype.restartApplication = function (aNext, aResetProfile, > + aUserRestart,aRestartFlag) { Nit: Missing whitespace after comma.
Attachment #770147 -
Flags: feedback?(hskupin)
Attachment #770147 -
Flags: feedback?(dave.hunt)
Attachment #770147 -
Flags: feedback+
Comment 3•11 years ago
|
||
Comment on attachment 770147 [details] [diff] [review] patch v1 Review of attachment 770147 [details] [diff] [review]: ----------------------------------------------------------------- All this is not necessary anymore. I have already added this to my patch on bug 865690 which landed end of last week.
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•