888865 - [MMS] The name of the sent image is wrong in FFOS device

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Leo]

1. Title: The name of the sent image is wrong in FFOS device
2. Precondition: Device should be able to send and receive MMS
3. Tester's Action: 1) SMS -> New ->Attach image from Gallery
                    2) Send the MMS message with attached image.
                    3) Save the received image on the other device.
                    4) Check the name of the saved image.
4. Detailed Symptom (ENG.) : The name of the image is saving as 'sdcardDCIM +image name'
5. Expected: The received image should be saved with only the image name
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision: 613e69ee0a009399130ad2cbb8b9d0462cd1fc70
9. Personal email id: [e-mail]

Comment 1

[Gene Lian (I already quit Mozilla)]

Sounds like a Gaia issue when preparing the SMIL and files.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10790

Please kindly help to review.

Comment 3

[Steve Chung [:steveck]]

Hi George, I left some comment in https://github.com/mozilla-b2g/gaia/pull/10790#issuecomment-20472840, and please remember to perform the test with other devices, thanks.

Comment 4

[Leo]

Hi George Duan,

We have tested this patch.
case 1).After sending the image from the FFOS device,
   a) Open the image in the sending device
   b) See the name of the image on the top before save option.
   c) The name is shown as proper
case 2).But,Once the image is sent to android device
   a) Open the attachment.
   b) Long press on the image to get the save option
   c) check the name of the image
   d) The image name is shown with the full path in the android device.
      For example,if the image is saved in sdcard/DCIM path,the image name is shown as "sdcard/DCIM/Image Name"

The problem still exists in the receiving device(second case).Please check the second scenario.

Regards,

Comment 5

[Wayne Chang [:wchang]]

ni?george for comment 4

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

In reply to comment 4,

I updated a new patch and tested with my own android as receiver. The filename seems correct. I think the filename is identified as the src of the smil element or the id string or the blob's name by receiver, but either of them doesn't contain string as 'sdcard/DCIM/Image name' in new patch.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 771245 [details]
https://github.com/mozilla-b2g/gaia/pull/10790

Patch updated for below reasons.
1. src is identified as file's name.
2. Tested on my android, mms identify file's source by attachment's location, if any mismatch, the image will not show directly, so I set them with its filename.
3. To avoid different files with same names may display incorrectly, refer to how android does, I put number in the the end of file name (image.jpg and image_2.jpg)
4. add test case for reason 3.

Comment 8

[Corey Frang [:gnarf]]

Comment on attachment 771245 [details]
https://github.com/mozilla-b2g/gaia/pull/10790

found a problem with the de-duplication of filenames and submitted a patch - https://github.com/mozilla-b2g/gaia/pull/10790#issuecomment-20701769 - please r? me again when updated - thanks!

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 771245 [details]
https://github.com/mozilla-b2g/gaia/pull/10790

Thanks , I just merged your suggestion. Please kindly review it again.

Comment 10

[Corey Frang [:gnarf]]

Comment on attachment 771245 [details]
https://github.com/mozilla-b2g/gaia/pull/10790

r=me

Comment 11

[Corey Frang [:gnarf]]

master: https://github.com/mozilla-b2g/gaia/commit/05dbbbcb9706f4e2f0d270598e7745d84dbc95d4
v1-train: https://github.com/mozilla-b2g/gaia/commit/be7682e9186660a9ea0cc183c49e31c707166cb5

Comment 12

[:CSchmoeckel]

In MozTrap added MMS Suite Test Case #9002 - Verify that the name of an image is not changed when sending it to another device via MMS

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: be7682e9186660a9ea0cc183c49e31c707166cb5