Closed
Bug 889055
Opened 11 years ago
Closed 11 years ago
render_test.js failing in TBPL
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Firefox OS Graveyard
Gaia::Keyboard
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: janjongboom)
References
Details
Attachments
(1 file)
46 bytes,
patch
|
rudyl
:
review+
|
Details | Diff | Splinter Review |
log: https://tbpl.mozilla.org/php/getParsedLog.php?id=24794681&tree=Cedar 12:22:25 INFO - gaia-unit-tests TEST-UNEXPECTED-FAIL | Renderer resizeUI All keys should have same visual width if fully used | expected 0 to equal 0 12:22:25 INFO - gaia-unit-tests INFO | stack trace: 12:22:25 INFO - Error: expected 0 to equal 0 12:22:25 INFO - at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30) 12:22:25 INFO - at notEqual (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1276) 12:22:25 INFO - at (anonymous) (http://keyboard.gaiamobile.org:8080/test/unit/render_test.js:91) 12:22:25 INFO - at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62) 12:22:25 INFO - at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 12:22:25 INFO - at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127) 12:22:25 INFO - at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016) 12:22:25 INFO - at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3979) 12:22:25 INFO - at done (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3700) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3712) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:46) 12:22:25 INFO - at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:73) 12:22:25 INFO - at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709) 12:22:25 INFO - at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984) 12:22:25 INFO - at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932) This test has been disabled in TBPL only because it always fails; we're trying to get a green run so we can turn the tests only globally.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → janjongboom
Assignee | ||
Comment 1•11 years ago
|
||
I think this is because in TBPL we're running in a headless browser or a browser with width/height of 0, but I have no easy way to verify this. If so, this should fix it.
Attachment #770066 -
Flags: review?(rlu)
Comment 2•11 years ago
|
||
Comment on attachment 770066 [details] [diff] [review] Patch Looks good to me, though I don't know have to test this with TPBL. I guess we could just make it landed to go through the test process. Jan, Thanks for taking care of the unit test.
Attachment #770066 -
Flags: review?(rlu) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Landed in https://github.com/mozilla-b2g/gaia/commit/e8fb583e3369d5109946eb556a13d81a617f91e5 Let's see if this fixes it.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•