Closed Bug 889465 Opened 11 years ago Closed 9 years ago

Buttons need GC tests

Categories

(Add-on SDK Graveyard :: General, defect, P2)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: evold, Assigned: zer0)

References

Details

Attachments

(1 file)

      No description provided.
Priority: -- → P2
Assignee: nobody → zer0
Erik, what kind of test did you have in mind? The buttons test already include some GC tests.
Flags: needinfo?(evold)
(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #1)
> Erik, what kind of test did you have in mind? The buttons test already
> include some GC tests.

If I create a button `ActionButton({ ... })` and don't assign it to a variable, such that the add-on instance is GC'd then should the button exist still? I think so, and we need a test for that by creating a button, running gc, and checking that the button still exists in the window dom, and behaves properly.
Flags: needinfo?(evold)
Comment on attachment 8498829 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1670

Thanks!
Attachment #8498829 - Flags: review?(evold) → review+
Hey Matteo, is this ok to land?
Flags: needinfo?(zer0)
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f71e768992a537b4839c687173d13b740d7b1296
Bug 889465 - Buttons need GC tests

- Added the GC tests required

https://github.com/mozilla/addon-sdk/commit/60560564ba3d15323ee60d41979ed682fe1d6cfb
Merge pull request #1670 from ZER0/test-button-gc/889465

fix Bug 889465 - Buttons need GC tests r=@erikvold
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
I thought I already land that stuff, sorry!
Flags: needinfo?(zer0)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: