Closed
Bug 889466
Opened 11 years ago
Closed 11 years ago
Lockscreen uses mouse events for gestures when it should be using touch events
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdas, Assigned: kgrandon)
References
Details
(Whiteboard: c= p=2)
Attachments
(1 file)
When attempting to automate gestures on the lockscreen using touch events like other gaia apps, we discovered that the lockscreen is expecting mouse events. When doing a swipe gesture, like the one needed to pull the lockscreen area handle, mouse events are needed, when it should be touch events. This goes against the de-facto standard we're using of 'mouse events for click, touch events for everything else', and so it breaks compatibility with our gesture automation and blocks bug 831852.
Comment 1•11 years ago
|
||
Kevin, mind looking into this when you get a chance, per IRC? Thx :-)
Flags: needinfo?(kgrandon)
Updated•11 years ago
|
Flags: needinfo?(timdream)
Updated•11 years ago
|
Flags: needinfo?(timdream) → needinfo?(yurenju.mozilla)
Comment 2•11 years ago
|
||
I'm a little busy with hd+ bugs, maybe Kevin can help on this?
Flags: needinfo?(yurenju.mozilla)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kgrandon
Flags: needinfo?(kgrandon)
Whiteboard: c= p=2
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 772264 [details]
Github pull request pointer
Hi Alive, Yuren,
Wondering if one of you could take a look at the lockscreen patch in this commit. Depending on when you look there may be an extra patch here which fixes gaia in nightly (that is going as part of another bug though).
Attachment #772264 -
Flags: review?(yurenju.mozilla)
Attachment #772264 -
Flags: review?(alive)
Comment 5•11 years ago
|
||
Comment on attachment 772264 [details]
Github pull request pointer
Code looks OK to me. Feedback? to :yuren.
Though I don't know why two different bug commits are gathered here..
Attachment #772264 -
Flags: review?(yurenju.mozilla)
Attachment #772264 -
Flags: review?(alive)
Attachment #772264 -
Flags: review+
Attachment #772264 -
Flags: feedback?(yurenju.mozilla)
Comment 6•11 years ago
|
||
Comment on attachment 772264 [details]
Github pull request pointer
looks good to me, but travis-ci error. I restarted build, so please wait travis result.
Attachment #772264 -
Flags: feedback?(yurenju.mozilla) → feedback+
Comment 7•11 years ago
|
||
looks good for second run :D https://travis-ci.org/mozilla-b2g/gaia/builds/8860879
Assignee | ||
Comment 8•11 years ago
|
||
Landed in master: https://github.com/mozilla-b2g/gaia/commit/95ab47bbd5bef22050e726d35fd00128f2cc2785 Thanks guys!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
This patch breaks desktop build since we don't support touchevent there :-o May need a bug for faking touchevent in desktop build.
You need to log in
before you can comment on or make changes to this bug.
Description
•