Closed
Bug 889526
Opened 11 years ago
Closed 11 years ago
Improve reportError so that it will add a stack trace if one is available
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: fitzgen, Assigned: fitzgen)
Details
Attachments
(1 file)
|
2.89 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
We shouldn't just pass the error on to Cu.reportError. If the argument passed is an error object, we should construct an error message ourselves so that we can make sure we get a stack if one is available.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → nfitzgerald
|
|
Assignee | |
Comment 1•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=3e426ea802ef
Attachment #770373 -
Flags: review?(rcampbell)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 770373 [details] [diff] [review] v1 Forgot that robcee is semi-unavailable this week.
Attachment #770373 -
Flags: review?(rcampbell) → review?(past)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 770373 [details] [diff] [review] v1 Review of attachment 770373 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #770373 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/18bf64501c80
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/18bf64501c80
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•