889838 - Silent exception when inspecting debugger variables on old actors (b2g-18 ones)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Alexandre Poirot [:ochameau]]

While working bug 817580, I noticed that variable inspection was silently failing when being connected on old actors (using m-c 18 branch). Both sides seem to work correctly as exchanged packets look correct:

{"to":"conn1.child1016:obj55","type":"prototypeAndProperties"}                
=>
{"from":"conn1.child1016:obj55","prototype":{"type":"object","class":"Object","actor":"conn1.child1016:obj84"},"ownProperties":{"name":{"configurable":true,"enumerable":true,"writable":true,"value":"touchStartedState"},"init":{"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"                   | conn1.child1016:obj33"}},"touchstart":{"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj80"}},"touchmove":{"configurable":true,"enumerable":true,"writable":true ,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj81"}},"touchend":{"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj82"}},"holdtimeout":        {"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj83"}}}}

But this code is throwing an exception:
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/VariablesViewController.jsm#126
  let { ownProperties, prototype, safeGetterValues } = aResponse;

As b2g18's actor doesn't send the safeGetterValues property...

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Silent exception when inspecting debugger variables on old actors

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 770814 [details] [diff] [review]
Silent exception when inspecting debugger variables on old actors

Review of attachment 770814 [details] [diff] [review]:
-----------------------------------------------------------------

That was the issue I was refering to today on irc!
With that I can inspect variable on b2g18 from firefox nightly \o/

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 770814 [details] [diff] [review]
Silent exception when inspecting debugger variables on old actors

Review of attachment 770814 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/849066268881

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/849066268881