Closed Bug 890239 Opened 11 years ago Closed 11 years ago

nsSystemTimeChangeObserver::RemoveWindowListenerImpl leaks the weak reference

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla25

People

(Reporter: Ms2ger, Assigned: ehsan.akhgari)

Details

(Keywords: memory-leak)

Attachments

(1 file)

Patch (v1)
1015 bytes, patch
justin.lebar+bug
: review+
Details | Diff | Splinter Review 
NS_GetWeakReference returns an already-addrefed raw pointer, which isn't released. Prefer do_GetWeakReference.
Ccing code author and reviewer...
Flags: needinfo?(slee)
Flags: needinfo?(justin.lebar+bug)
Attached patch Patch (v1) — — Splinter Review 
Assignee: nobody → ehsan
Status: NEW → ASSIGNED

        Attachment #771367 -
        Flags: review?(justin.lebar+bug)

    
    

    
  
Comment on attachment 771367 [details] [diff] [review]
Patch (v1)

r=me; thanks for catching this.

        Attachment #771367 -
        Flags: review?(justin.lebar+bug) → review+
Flags: needinfo?(slee)
Flags: needinfo?(justin.lebar+bug)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/60eb83902698
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: