Closed Bug 890538 Opened 11 years ago Closed 10 years ago

[meta] Update API handling & response codes for the Login server

Categories

(Webmaker Graveyard :: Login, defect)

Product:
Webmaker Graveyard
Component:
Login
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: mjschranz, Assigned: sedge)

References

Details

Attachments

(1 file)

https://github.com/mozilla/login.webmaker.org/pull/140
54 bytes, text/x-github-pull-request
humph
: review-
Details | Review 
This stems from the following comment https://github.com/mozilla/node-webmaker-loginapi/pull/20#discussion_r5046276.

Right now the login server returns an actual error when it doesn't find a user yet it's status code is 404. This lead to a problem with account creation in recent SSO changes.

We should sort this out to make it nice and clear for consuming applications.
Assignee: nobody → kieran.sedgwick
Status: NEW → ASSIGNED
Summary: Review server responses when retrieving user data → Review server responses for the LoginAPI
Depends on: 875945
This bug now covers four patches:

1) Updating API design documentation
2) Updating the server logic, response codes and unit tests
3) Updating the node-webmaker-loginapi client library
4) Updating client-side calls to the login server
Summary: Review server responses for the LoginAPI → [meta] Update API handling & response codes for the Login server

        Attachment #786385 -
        Flags: review?(david.humphrey)

    
  

        Attachment #786385 -
        Flags: review?(cade)

    
    

    
  
Comment on attachment 786385 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/140

I left some comments in the pull request for you to ponder upon.

        Attachment #786385 -
        Flags: review?(cade) → review-

    
    

    
  
Sedge, do you want to fix Cade's stuff and then flag me again?

        Attachment #786385 -
        Flags: review?(david.humphrey)

    
    

    
  
Comment on attachment 786385 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/140

Ready for ya now!

        Attachment #786385 -
        Flags: review- → review?(david.humphrey)

        Attachment #786385 -
        Flags: review?(david.humphrey) → review-

    
  
Blocks: 916149
Attachment mime type: text/plain → text/x-github-pull-request

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: