891203 - 404 page replaces invalid url's protocol from HTTPS to HTTP in the link to file bug on Bugzilla

Status: VERIFIED WORKSFORME

(Socorro :: Webapp, task)

Description

[Vaidik Kapoor [:vaidik]]

Steps to reproduce:
1. Go to https://crash-stats.mozilla.com/invalid
2. Observe the "bug_file_loc" GET parameter of the link "issue in Bugzilla".

Expected value:
Current page's URL i.e. https://crash-stats.mozilla.com/invalid

Observed value:
Protocol is changed to HTTP i.e. http://crash-stats.mozilla.com/invalid

This is observed only on Prod and not on Dev/Stage.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

xref bug 631737 - I'm not sure why we're seeing this again, now.

Comment 2

[Robert Helmer [:rhelmer]]

(In reply to Vaidik Kapoor [:vaidik] from comment #0)
> Steps to reproduce:
> 1. Go to https://crash-stats.mozilla.com/invalid
> 2. Observe the "bug_file_loc" GET parameter of the link "issue in Bugzilla".
> 
> Expected value:
> Current page's URL i.e. https://crash-stats.mozilla.com/invalid
> 
> Observed value:
> Protocol is changed to HTTP i.e. http://crash-stats.mozilla.com/invalid
> 
> This is observed only on Prod and not on Dev/Stage.

We are using {{ request.build_absolute_uri() | urlencode }} in the Jinja template ( see https://github.com/mozilla/socorro-crashstats/blob/master/crashstats/base/templates/404.html )

I suspect this is because the server is HTTP and SSL is terminated at the loadbalancer (zeus)...

peterbe, if the above is correct I think we might have to pull the server URL from the settings and build a relative path instead, what do you think?

Comment 3

[Peter Bengtsson [:peterbe]]

It's because it's not configured correctly. An environment variable tells Django to construct absolute URLs with https and it wasn't set up. 

I filed the dependent bug many days ago but stalled it because I was waiting for a more urgent feature to land but that's been taken care of. 

So once 881813 is resolved this bug should automatically resolve itself but it would be good to verify it first.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Peter Bengtsson [:peterbe] from comment #3)
> It's because it's not configured correctly. An environment variable tells
> Django to construct absolute URLs with https and it wasn't set up. 
> 
> I filed the dependent bug many days ago but stalled it because I was waiting
> for a more urgent feature to land but that's been taken care of. 
> 
> So once 881813 is resolved this bug should automatically resolve itself but
> it would be good to verify it first.

It's not.

http://crash-stats-dev.allizom.org/jfskdl

https://bugzilla.mozilla.org/enter_bug.cgi?product=Socorro&component=General&bug_file_loc=http%3A%2F%2Fcrash-stats-dev.allizom.org%2Fjfskdl

Still "http".

Comment 5

[Peter Bengtsson [:peterbe]]

Thought it was related to https://bugzilla.mozilla.org/show_bug.cgi?id=881813 but perhaps it's not.

Comment 6

[Peter Bengtsson [:peterbe]]

No. The code is good. See http://cl.ly/QH66

https://bugzilla.mozilla.org/show_bug.cgi?id=881813 updated stage and prod.

Comment 7

[Matt Brandt [:mbrandt]]

QA verified on stage and prod