891334 - PDF File upload : wrong mime type (js)

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[dr_fx59]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

I am using an input of type file to upload pdf using ajax on Firefox 22.0


Actual results:

I want to check the file mime type to be sure to get a pdf.
So I am using this javascript : 
var file = uploader.container.find('input[type="file"]')[0].files[0];

then I check the property  'type' of the file var. (file.type)

The value is 'application/octet-stream' instead of 'application/pdf' !



Expected results:

The value of file.type should be  'application/pdf'.

The same code with the same file works on IE10 and Chrome 28.0.1500.71.

Comment 1

[Paul Silaghi, QA [:pauly]]

Yury, any suggestions please ?

Comment 2

[Josh Matthews [:jdm]]

I think we've got two choices here: if the OS does not appear to be providing us with any good hint, we can add the pdf extension to the list extraMimeEntries list in nsExternalHelperAppService, or we could rely on pdf.js to add a MIME entry for PDFs via the ext-to-type-mapping category. Personally, I think we would want this regardless of the presence of pdf.js.

Comment 3

[Josh Matthews [:jdm]]

Boris, you seem to have reviewed changes to the extraMimeEntries list in the past. Would adding one for PDF make sense here?

Comment 4

[Boris Zbarsky [:bzbarsky]]

I think adding PDF there is totally reasonable.

Comment 5

[Josh Matthews [:jdm]]

This will be a very simple change for someone to make.

Comment 6

[Biru [:poiru]]

Attachment: Add default MIME type definition for .pdf as 'application/pdf'

Comment 7

[Josh Matthews [:jdm]]

Thanks!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/02acc75e4e0c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/02acc75e4e0c

Comment 10

[dr_fx59]

Thanks !