891366 - provide unit test script with gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Gaia has some nice infrastructure for executing unit tests, but currently there are a few hurdles for new developers to start running them.  I'd like to propose that we commit a script similar to what is described here:

  https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Testing/Gaia_unit_tests

I have a version of the script with some additional checking that might work as a starting point.  I'll attach a pull request.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Pull request at https://github.com/mozilla-b2g/gaia/pull/10867

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

This script could certainly use improvements in terms of command line optins, looking for firefox in reasonable places for Mac, etc.  It might be a good starting point, though.

I also added a make target that runs the server, so you can just run:

  make test-unit

Maybe not the best target name since it just runs the server and firefox.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Talked to lightsofapollo on IRC and got an informal f+.  He'd like to see the README updated and have it reviewed by someone with more bash experience, though.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 772666 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/10867

I've updated the pull request to add the script to the README.md section on unit tests.  I added it as a shortcut instead of replacing the full explanation.

Asking for review from mwu as the resident shell script guru.  :-)

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 772666 [details]
Pull request at https://github.com/mozilla-b2g/gaia/pull/10867

Look ok to me, but I'm not entirely familiar with the unit tests here. Guess we'll just have to land and see if people hit problems.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Thanks!  Merged:

  https://github.com/mozilla-b2g/gaia/commit/10bb911bd9eff3287d4fe35379b8b310a84e5fb9

I also updated the wiki here:

  https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Testing/Gaia_unit_tests#Launch_the_server_and_Firefox_Nightly

Please let me know if there are any problems.